[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/14] scsi: remove outdated AioContext lock comment
- To: qemu-devel@xxxxxxxxxx
- From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- Date: Tue, 5 Dec 2023 13:20:09 -0500
- Cc: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Cleber Rosa <crosa@xxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Ari Sundholm <ari@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Juan Quintela <quintela@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Zhang Chen <chen.zhang@xxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 05 Dec 2023 18:20:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The SCSI subsystem no longer uses the AioContext lock. Request
processing runs exclusively in the BlockBackend's AioContext since
"scsi: only access SCSIDevice->requests from one thread" and hence the
lock is unnecessary.
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>
---
hw/scsi/scsi-disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 61be3d395a..2e7e1e9a1c 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -355,7 +355,6 @@ done:
scsi_req_unref(&r->req);
}
-/* Called with AioContext lock held */
static void scsi_dma_complete(void *opaque, int ret)
{
SCSIDiskReq *r = (SCSIDiskReq *)opaque;
--
2.43.0
|
