[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Tue, 5 Dec 2023 06:50:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7f6RNUL+Ut+CYXBUDWZ4JCiI5JMo8p99RsiMYMVlPc0=; b=PeV0iWLujT6KTKGYw5Q/mZCpUvb75Vtq585IkZCs1Kc8ZVXREizce3cGP7PVuloog57/yyerc6vwhTFFJYR3/CeI0zptgsqQACZKr0vEv5qtxwKALN4qLCAMqadc8gBrduSqAMjT+Iwv5IeI8EyrjaraH/czki8RX42mtp6hZwfcluuTfPb4qJI19KKFKiDZoCqXl8/dAAAKUnGlldwKBCR8hs/nQ6x9ofj1m8rN2OdZUnIJodTasfDqy1RQrdndGctSk4WHrbWVz/iZ/NlET/Rxb8DFL1TXxA2hv6NgVi95z90idlFdC740WEcds5aeCXO0j3N9cvhHql84ft0tDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UXZyjhPZBsrP9/NCInsoEaxUySuWaJw8KkDbsD7a3oVqiws4W/495qKi566K2VV5cucRD0kVaZz1Ksyqm9GrFykApP4UwYQWnIGBFGLKxSteJWk0pKkoSbLlsYwTnrzF8mNAc0yA7WUbS1z47b54KhJ+WYsCxXPLa8hjlHW4PT5lJUFZhJN9mkpNwQTmWoBVzYHd6dxPqIffYBhdBdhzE3pwdymmvdfCGr9q08xK4OSuERMzmZ1Rxux7lBit5drsYpSl60uObb/LlxVkjaQck5zIrAC4nV9mLzxQz9lv/i24xom/sOk5FC9nD3bGF/TRXtdzdF0OJ37jNEdj7C5eZw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Koenig, Christian" <Christian.Koenig@xxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Tue, 05 Dec 2023 06:51:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaHsGaWb8EJvAynUiF4JhdQXSstLCY0coAgACRkoCAAFGagIABIYqA
- Thread-topic: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function
On 2023/12/5 05:31, Stefano Stabellini wrote:
> On Mon, 3 Dec 2023, Chen, Jiqian wrote:
>>>> vpci device state when device is reset on dom0 side.
>>>>
>>>> And call that function in pcistub_init_device. Because when
>>>> we use "pci-assignable-add" to assign a passthrough device in
>>>> Xen, it will reset passthrough device and the vpci state will
>>>> out of date, and then device will fail to restore bar state.
>>>>
>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>>>
>>> This Signed-off-by chain is incorrect.
>>>
>>> Documentation/process/submitting-patches.rst has a full chapter about
>>> S-O-B and the correct usage.
>> I am the author of this series of patches, and Huang Rui transported the v1
>> to upstream. And now I transport v2. I am not aware that the SOB chain is
>> incorrect.
>> Do you have any suggestions?
>
> I think he means that your Signed-off-by should be the second one of the
> two as you are the one submitting the patch to the LKML
Got it. Thanks Stefano! I will adjust the sequence in next version.
--
Best regards,
Jiqian Chen.
|
