[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/domain: fix error path in domain_create()
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Mon, 4 Dec 2023 22:29:11 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zH1n2UOyz3e/Zk+LuK0xB0Y+U90M5mdvOerHQwWk3lI=; b=mWq+m0vSJgwuMj/43wbMk77627WybAcyjGXDr5Ywd3ORE5mKorhrPO9kJWgw1AOPnWhcXyrza2c/y4WyExZH3ajproGSHQccbNpDnMYgx/ytYQHiG3tfMZpuXdmxdmHG0DjqhFJEKzb3Kp1H57+vDX/iaC/n7Vk8+9Nhwn1EyrXrOy2m91siz8AqhGagrMVoYGcw+akYVtreEsus4QJv7gLbz40oFihbyVk9Q5Vq4n7yEgHei+drfTHo3jNFtGr+422uGpXWVMFfDQmYPdUE1wetuAr/ZKwXDjgk35XacfzmKIwgyJo5P0AwkQyHucc+c9Vm24c6+oS8VRefUQO+1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQvjr9Jy2pi1955VIC0VzHCzpy1nYf/vD0W3pDPlH7Hwynl2Ogn4jleRYvs6RJekNKUiLDkwaoDY6RtSq9HoOGtfwzyS7YcvaR5lOGVaoD6QWmFFvR6azRVC8LlaPVE95dO+MHh80XWxkr14pw5LoFid/DROgWEERCZtU96xbxBVntEvMZd19gakDLclnrDKS+stpmkox7qyfhaQHmqWceyXEg5X4ElKU+7VvLNzh5VbyopBuPHfIAiOndbMTCcn0VpVchUyEceRuGm+iOnPlpAhXkVeFwBnT+lQvH34xRfBEa27fduE0I3awrw2e7WFGrdLvaULdm1PLq3E8bMahA==
- Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 05 Dec 2023 03:29:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
If rangeset_new() fails, err would not be set to an appropriate error
code. Set it to -ENOMEM.
Fixes: 580c458699e3 ("xen/domain: Call arch_domain_create() as early as
possible in domain_create()")
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
---
xen/common/domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/common/domain.c b/xen/common/domain.c
index cd2ca6d49a5e..c5954cdb1ac2 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -710,6 +710,7 @@ struct domain *domain_create(domid_t domid,
watchdog_domain_init(d);
init_status |= INIT_watchdog;
+ err = -ENOMEM;
d->iomem_caps = rangeset_new(d, "I/O Memory",
RANGESETF_prettyprint_hex);
d->irq_caps = rangeset_new(d, "Interrupts", 0);
if ( !d->iomem_caps || !d->irq_caps )
--
2.43.0
|
