[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 09/17] rangeset: add rangeset_empty() function
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Tue, 5 Dec 2023 00:52:39 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GqwPNLlBenU8Aph9VxiP0M2gcBQwU8At8YPIwJb06v4=; b=Ym6IIN/EgmmZJj6OzaL8bQ86F1cyMEr5lAcE0CWevvWgfhdzLFRxWvspvL81YuzY/uaRMT5iOkrvOdTv2CULWgtxjGWo0lVCMq5wXlAwGW8ZMK/rTWU5Rt7tILr5TcSRlkOZWjaz8CoO64rRSV+5G3ZaLewmZrpTnGQ9vz8gGrDBG3LDs0WFTvcdGo6LWF+TQTHjaXjbzUON43l9y4VOIrDORTAdhKhmHcFtvC18ObXgBmCyxcIqHCYTAhxTpCDlZZDIQqE9h9/YRUyJRjODkR/vlSEQhnKihMZSKzYqBkQIetl68LU0X8aEl63b5rgQhU9mhEMdUK2OV1EIdqbIdw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JCaR55m2Hw+t/SESfVOTcWhuCzk1BzCOCrCt+d4OLlVhKAR18wNhikJLxctnFX6NKfG5H0EhAOHNqMkVpFnvQQQzaaYzwd62NyDSfWqbwQ60ISZzUCnXRH1s1FVrXmmlkvFEl9XyBvK948tzGVdbut9CoVKeLblGJTO8TgmN9mMB3cdVS4DRokxj2YW9D80ZtmgMmJyAt3QnO9Gs9o105f1JtvQnSBCM88CM2rajD7O9zitfao5b4yp94t9+Do4r2mbAkw1Kl+HMqdHCCVN0+b6wXBpsin3rYsoHM4ejF93aigEA6T4KoFJrOWrdrUcYar3nVFmUkmfUxOgu+KJIpw==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 05 Dec 2023 00:53:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaJL6oz4wJTetDeUydVFKkkhEQHrCY0GYAgAEQN4A=
- Thread-topic: [PATCH v11 09/17] rangeset: add rangeset_empty() function
Hi Jan,
Jan Beulich <jbeulich@xxxxxxxx> writes:
> On 02.12.2023 02:27, Volodymyr Babchuk wrote:
>> This function can be used when user wants to remove all rangeset
>> entries but do not want to destroy rangeset itself.
>
> I have to admit that I'm not happy with the name: We're not consistently
> naming all predicate-like helpers is_...() (see e.g. cpumask_empty()).
> May I suggest to use something which unambiguously expresses an action to
> be taken, e.g. rangeset_purge(), rangeset_reset(), or (less suitable as
> some ambiguity would remain, yet it would be in line with e.g.
> cpumask_clear()) rangeset_clear()?
Naming this is not my best trait, so I am open for any suggestions. From
all proposed variants I like rangeset_purge() most. So if there are no
other objections, I'll rename this function in the next version.
--
WBR, Volodymyr
|
