[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 16/17] xen/arm: vpci: permit access to guest vpci space


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • Date: Mon, 4 Dec 2023 11:16:03 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9WWyHuCzZCX1QFVOEv+VPJ7iAgNzOwSmkPflLsMLbqs=; b=QXxo9J7+6CpxOxNp2+mlKjhbvlzxFkPklmHozvgmw729ZxnjQa0grnM0vZWlPL1+P/pZ3l54NDLS9gHWUCJIF3glUryZIGrYRiRIvCzhCSKP1Mhb4AzNlh52wPTDUwP6rm0NyAh7Ks+THye0+aMwx3RP6WQI1JR8vwWjg7SP9CSszNngEpXSlmXhYvPU74qhgds4GlY5F8UjowQIC6mJCHrRcW6WjClJRDpVIJg6o1mc3lAhymaAZvr892HgL8yfyVlogH6QSbDK0qjfGY9Mg0m1Ia4Wlk9NctUlIcDK9ZHbUEaZP4qgnlAqz5foViQe80HZNbMFpjeY3vUnfhckYg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ipfg1Oa9AQP+JysetJ1xpNy61o2NXLcr++sTCwXUrx0TcoJs67sszfnEigSbTRFH1NCABc5a0mRL5sX1cC/ten7dEppnyRt9xE9SzxWNoN5RerIJQLCsTGZ90IVjyyKCi6wCrM6zt84mWjVXW89gj0i+TLf679j1e77b35LTEFMjQ6YpVBHlBhth9CWyrvyvm2pu1fyCRAphs7Xicy4PiM7icLExpWU6GdObpFYAIl0UVUEAtvz8FU3pPW0wUlUP8oa4DapgY4VtgYF2PFog1QU967aR7k/UduwgJ8aQiweg2L15TMJsklzxQrekpgOojqV82RPGF4xmyeq8x6s0GA==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "George Dunlap" <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 04 Dec 2023 16:16:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12/4/23 03:29, Jan Beulich wrote:
> On 02.12.2023 02:27, Volodymyr Babchuk wrote:
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -695,6 +695,9 @@ struct domain *domain_create(domid_t domid,
>>          radix_tree_init(&d->pirq_tree);
>>      }
>>  
>> +    if ( !is_idle_domain(d) )
>> +        d->iomem_caps = rangeset_new(d, "I/O Memory", 
>> RANGESETF_prettyprint_hex);
>> +
>>      if ( (err = arch_domain_create(d, config, flags)) != 0 )
>>          goto fail;
>>      init_status |= INIT_arch;
>> @@ -711,7 +714,6 @@ struct domain *domain_create(domid_t domid,
>>          watchdog_domain_init(d);
>>          init_status |= INIT_watchdog;
>>  
>> -        d->iomem_caps = rangeset_new(d, "I/O Memory", 
>> RANGESETF_prettyprint_hex);
>>          d->irq_caps   = rangeset_new(d, "Interrupts", 0);
>>          if ( !d->iomem_caps || !d->irq_caps )
>>              goto fail;
> 
> I'm pretty sure I asked before why I/O mem caps' init would be moved, but
> IRQ caps' would remain where it is.

You did. Sorry about that, I made the change locally but forgot to propagate it 
to Volodymyr. I will reply here with the updated patch.

> 
> Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.