[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 3/7] xen/x86: add missing instances of asmlinkage attributes
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 1 Dec 2023 09:47:47 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CEHChxh/eplANRe4gyktVXGXTWsC4x+ZsBVwLKuG7tk=; b=UP5bqWVH43uuIrHal7OJM3BVcPwA0MuCBwq0ezn9bRHnE/eoNopy7++J98YzVTouS+eoK2AsqBIX2Ndcs5XpoezKutHcluqNK+KcT0V7CoBzfnxW7yc0S4Anos8AI3HzJ0dkN6cfTWlYKgvrMa3sAAn4wYE2agNJ3dDpiPEImCm3GvsV+cgczNmNe5afvhf/qJgH0sRS/xG61OZ4xkLLkJNtNuxdQ/20jy/ih/4X9VwRa5BxA1wO0eoojM8PiTHCvg1KxnfNAmysK/upL/xmzNdpDJqVP8Isfnbq6KYJ7WfNlrbJp+KtMcSkqNntTrbPCkGlwCoqdEL++jSiII6YuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IM6Ca9Ihh6u7ZCkUmzO1f0rW/VwtkjrBZYRqM7RxUnbnPtRQa/IXsgxqG8zFByo8U6qGJtl3SbjtLLe8hrzgcsfBXNaWXVALZrsymySWIg5Q2+t/Mn+yu4KJTEfXWkCAaytR6pIp6uDCyc3cDkkUU/bsU97Neh8/UqajHP1DYlxhQWNIwaPZJtf+t/QwqfKcTRv9StIig+5QR1ayXLxOyo8LDota8/kSq0r8b/ke4n+CJXV4Z1d6D3R1vDFP/SvxVIj+k/y9ADCXALTKJw+X4WBZVyr7m5kV1I/u8xmR0XwlAbl7i32rx+UgCn+WiIQig0ElFtjVL+9aC7aDphE0Ww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, bertrand.marquis@xxxxxxx, julien@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 01 Dec 2023 08:47:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.12.2023 09:42, Nicola Vetrini wrote:
> On 2023-11-30 17:44, Jan Beulich wrote:
>> On 29.11.2023 16:24, Nicola Vetrini wrote:
>>> --- a/xen/arch/x86/desc.c
>>> +++ b/xen/arch/x86/desc.c
>>> @@ -91,7 +91,7 @@ seg_desc_t boot_compat_gdt[PAGE_SIZE /
>>> sizeof(seg_desc_t)] =
>>> * References boot_cpu_gdt_table for a short period, until the CPUs
>>> switch
>>> * onto their per-CPU GDTs.
>>> */
>>> -const struct desc_ptr boot_gdtr = {
>>> +const struct desc_ptr asmlinkage boot_gdtr = {
>>> .limit = LAST_RESERVED_GDT_BYTE,
>>> .base = (unsigned long)(boot_gdt - FIRST_RESERVED_GDT_ENTRY),
>>> };
>>
>> I'm not convinced asmlinkage is okay to use on data. Recall that in
>> principle
>> it may expand to an attribute specifying a non-default calling
>> convention.
>> Such attributes cannot be assumed to continue to be possible to apply
>> to
>> non-functions, even if such may happen to work with a particular
>> compiler
>> version.
>>
>
> It's already being used on variables, I believe.
>
> xen/arch/x86/mm.c:l1_pgentry_t asmlinkage __section(".bss.page_aligned")
> __aligned(PAGE_SIZE)
> xen/arch/x86/setup.c:unsigned long asmlinkage __read_mostly
> cr4_pv32_mask;
> xen/arch/x86/setup.c:char asmlinkage
> __section(".init.bss.stack_aligned") __aligned(STACK_SIZE)
> xen/arch/x86/setup.c:unsigned int asmlinkage __initdata multiboot_ptr;
Yeah, I was fearing that something was overlooked earlier on.
Jan
> If you have concern about this particular variable, then we can fall
> back on SAF or just put a declaration in the appropriate place.
>
|
