Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-11-29 at 13:49 -0600, Shawn Anastasio wrote:
> On 11/27/23 8:13 AM, Oleksii Kurochko wrote:
> > diff --git a/xen/arch/arm/include/asm/numa.h b/xen/include/asm-
> > generic/numa.h
> > similarity index 76%
> > rename from xen/arch/arm/include/asm/numa.h
> > rename to xen/include/asm-generic/numa.h
> > index e2bee2bd82..b00fca4978 100644
> > --- a/xen/arch/arm/include/asm/numa.h
> > +++ b/xen/include/asm-generic/numa.h
> > @@ -1,12 +1,15 @@
> > -#ifndef __ARCH_ARM_NUMA_H
> > -#define __ARCH_ARM_NUMA_H
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +#ifndef __ASM_GENERIC_NUMA_H
> > +#define __ASM_GENERIC_NUMA_H
> >  
> > -#include <xen/mm.h>
> > +#include <xen/stdint.h>
> >  
> > -typedef u8 nodeid_t;
> > +typedef uint8_t nodeid_t;
> >  
> >  #ifndef CONFIG_NUMA
> >  
> > +#include <xen/mm-frame.h>
> > +
> >  /* Fake one node for now. See also node_online_map. */
> >  #define cpu_to_node(cpu) 0
> >  #define node_to_cpumask(node)   (cpu_online_map)
> > @@ -26,7 +29,8 @@ extern mfn_t first_valid_mfn;
> 
> Minor nit: in this part of the file (that wasn't included by git in
> this
> diff), there's a comment that references Arm:
> 
>  /*
>   * TODO: make first_valid_mfn static when NUMA is supported on Arm,
> this
>   * is required because the dummy helpers are using it.
>   */
>  extern mfn_t first_valid_mfn;
> 
> This should probably be changed to generic/GENERIC as you've done
> elsewhere in the series.
> 
> In any case,
> 
> Acked-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> 
Thanks. I'll update in next patch version.

~ Oleksii