[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Thu, 30 Nov 2023 08:38:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FYv330pRZs/M9ux+daWixG//PtJ1d2N9UXPhnHCSRIg=; b=EEQVPyriyuzftVnkH2uSDe0F53phydhp7ZSDKRRYEcprpImnGR1PTjQmDHwWyKSSzq06Axr5y7Nyyd8rRSnMGN/Yqpqev+Ale40+1o4iKFvHihbZzvRpIEUef11fKcq0FMOtI8egEmgS4w5zx+sCFoH+hGYn9BNymozRL8i5OESOTQI9SVTQEdE/GVILhMxdEHQMrCTLgE/s5I+WYAL/CopxE8qgN2o+4ZrE/Q5QD3CddpPALufQQcS6p9LsWYnp+VN/cL9vKk4cAh+YAuY20b7imQZyrxkYkMuRcHpHpS1p2HgH2JZPJW7XxmBa1GhesIScrfovOUVVXysIjV+y8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYFZDNraTBJ2sH5liyW32xLBEzkI3q2X2PfHBrNotD/DD5uuZgkLt+Fku8HJec5phJzNiSstgyYuhs0QymOQhqy0uFZ3LMS2TEyjfkcyxnXhxMAhXCjPfYkvjY3Q7EVrUNU1r1KHYdMz6Bh7Js/3W92VV6OUwXIztCqW8Nh0I7P0xtUP4vK4+w1ppF6Z4MnVWQPtR2RbSpH9t9PPjEoCnw0p4a4pIce6ugGw9hYgmLHc/3ZCSDkOeCqnlApOWMyhvCWIu60y+r0gw5D4+EMBRQJHa1CgVw1+sXAdGG9ueKA2a8H0L58uruo0tTrq0CYbYHjyV7QvlkNGVxmxFE/kGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Deucher, Alexander" <Alexander.Deucher@xxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Huang, Honglei1" <Honglei1.Huang@xxxxxxx>, "Zhang, Julia" <Julia.Zhang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 08:38:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHaHsLnjKJ102tGrkSg9na/6oLNI7CP3bYAgAMYyICAACIUgA==
- Thread-topic: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0
Hi Jan Beulich,
On 2023/11/30 14:44, Chen, Jiqian wrote:
>
> On 2023/11/28 23:14, Jan Beulich wrote:
>> On 24.11.2023 11:41, Jiqian Chen wrote:
>>> --- a/xen/arch/x86/hvm/hypercall.c
>>> +++ b/xen/arch/x86/hvm/hypercall.c
>>> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
>>> arg)
>>> {
>>> case PHYSDEVOP_map_pirq:
>>> case PHYSDEVOP_unmap_pirq:
>>> + if (is_hardware_domain(currd))
>>> + break;
>>> case PHYSDEVOP_eoi:
>>> case PHYSDEVOP_irq_status_query:
>>> case PHYSDEVOP_get_free_pirq:
>>
>> If you wouldn't go the route suggested by Roger, I think you will need
>> to deny self-mapping requests here.
> Do you mean below?
> if (arg.domid == DOMID_SELF)
> return;
>
>>
>> Also note that both here and in patch 1 you will want to adjust a number
>> of style violations.
> Could you please descript in detail? This will greatly assist me in making
> modifications in the next version. Thank you!
Oh! Do you mean there are many code style problems that not satisfiable for
CODING_STYLE of Xen in my codes?
Thank Xenia for reminder.
>
>>
>> Jan
>
--
Best regards,
Jiqian Chen.
|
