[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 30 Nov 2023 09:36:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YWlqujNL53Z1sthmdGXDFmwEMe3iTzE7S1q1huqLOFk=; b=BB365QHdstDC4509YeqS+AuYNJjKou4j9fIJuNfKbQmKKAsA9eDRiCZ8Sc4mQBOX7KsX9UAAFH6ixdbxV/OXAHyABjLFhVpP1jojgUUqnuUPaRiiWQUVR1b1J+DDa3N7pFnSnQ6W+eMmllbsGNbgfr18ljxdk0hSaeX8DW9n5jeziWXAXU7uQNdQkbi36hRa2JjYchxgerRlUe7iKrD4pa5E6xJytvvGvmb+HLsW4wD+FozFx2R6ZI+DyYEBNSFo8qzb7iglyY+r+h/5QqbPhC89uGG5HHruKKxcENlmbyAq1FVYTf5/PGK3p/uXrYb3JBeUYHwYb1aSXIo6Fr5cVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOHpU8H7VLiHnHzVxyHnnov6sCuUttHBTHJKCKcsPrbv4152rYWSHZsmRvBfPUaUD+FkK+EQ2p+YxDVvCC9JjWJHA943SvxuRV7DKQ2UTw9+X0PxwzDt+RcykqZ1j0aAQ11uACyl+hRTWtrcOtDQXDzow6dHejgcRhe2rvVjQsLT5QU96f5MVrdmQOFxiEL7Ip9lllM9So/UxWE0HlS/nm8bIVsq8Z63heJbliBHo2Lc+aoxz2uDsUMgAry3WY07rjqLKgjHOYW8TkuP0on13ZlhsmaI4DovtG/YAE6/Tnk/0N8IUw8J5xOEGCGGbi2/sBZR5Z3LNs3FH1JSYJFgUA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: Alexander Kanavin <alex@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 30 Nov 2023 08:36:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.11.2023 14:10, Anthony PERARD wrote:
> On Wed, Nov 29, 2023 at 11:47:24AM +0100, Julien Grall wrote:
>> + Anthony for the tools
>> + Juergen for Xenstored
>>
>> On 29/11/2023 11:34, Alexander Kanavin wrote:
>>> On 11/29/23 08:51, Jan Beulich wrote:
>>>
>>>> On 28.11.2023 18:47, Alexander Kanavin wrote:
>>>>> Such constructs are fully allowed by C99:
>>>>> https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations
>>>> There's more to this: It may also be a policy of ours (or of any
>>>> sub-component)
>>>> to demand that declarations and statements are properly separated.
>>>> This would
>>>> therefore need discussing first.
>>>
>>> The error is coming from python 3.12 headers and not from anything in
>>> xen tree, no? As you don't have control over those headers, I'm not sure
>>> what other solution there could be.
>>
>> We seem to add -Wno-declaration-after-statement for some components in
>> tools/. So one possibility would be to move the flags to an hypervisor
>> specific makefile (in xen/).
>
> You mean xen/Makefile I hope.
>
>> Anthony/Juergen, do you have any concern if the tools are built without
>> -Wdeclaration-after-statement?
>
> I don't, and as you said, there's already quite a few
> -Wno-declaration-after-statement.
>
> It can be nice to add a new variable in the middle of a function, it's
> like creating a new scope without adding extra indentation (if we wanted
> a new scope, we would need {} thus the intend).
To be clear, I wouldn't mind this in the hypervisor either. But then I also
don't see why we should further request people to separate declarations
from statements in an easily noticeable way. Thing is that imo something
like this wants spelling out in ./CODING_STYLE.
Jan
|
