[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/12] scsi: remove outdated AioContext lock comment
- To: qemu-devel@xxxxxxxxxx
- From: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
- Date: Wed, 29 Nov 2023 14:55:51 -0500
- Cc: Hanna Reitz <hreitz@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alberto Garcia <berto@xxxxxxxxxx>, Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Wen Congyang <wencongyang2@xxxxxxxxxx>, <qemu-block@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Xie Changlong <xiechanglong.d@xxxxxxxxx>, Ari Sundholm <ari@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxx>, Cleber Rosa <crosa@xxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>, Zhang Chen <chen.zhang@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Fabiano Rosas <farosas@xxxxxxx>
- Delivery-date: Wed, 29 Nov 2023 19:56:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The SCSI subsystem no longer uses the AioContext lock. Request
processing runs exclusively in the BlockBackend's AioContext since
"scsi: only access SCSIDevice->requests from one thread" and hence the
lock is unnecessary.
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
---
hw/scsi/scsi-disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index f1bd5f5c6e..ef0d21d737 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -351,7 +351,6 @@ done:
scsi_req_unref(&r->req);
}
-/* Called with AioContext lock held */
static void scsi_dma_complete(void *opaque, int ret)
{
SCSIDiskReq *r = (SCSIDiskReq *)opaque;
--
2.42.0
|
