Re: [PATCH v2] xen/arm64: Move print_reg macro to asm/arm64/macros.h

[Julien Grall <julien@xxxxxxx>]

Hi,

On 29/11/2023 10:06, Michal Orzel wrote:
> Macro print_reg is used to print a value of a register passed as an
> argument. While today it is only used from within the common head.S,
> in the future we might want to make use of it from other files, just
> like PRINT(). It also serves as a great aid when debugging.
>
> Expose print_reg macro by moving it to asm/arm64/macros.h and:
>   - rename putn to asm_putn to denote the usage from assembly only,
>   - use ENTRY() for asm_putn to make it globally visible.
>
> This way the behavior will be consistent with what we already do on arm32.
>
> Take the opportunity to get rid of unneeded stubs for early_puts,
> init_uart and putn since the calls to them are already protected by
> respective #ifdef CONFIG_EARLY_PRINTK.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
This is now committed.

Cheers,

--
Julien Grall