| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 Re: [PATCH v12 23/37] x86/fred: Make exc_page_fault() work for FRED
 
To: Xin Li <xin3.li@xxxxxxxxx>From: Borislav Petkov <bp@xxxxxxxxx>Date: Tue, 28 Nov 2023 11:02:42 +0100Authentication-results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key)	header.d=alien8.deCc: linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,	linux-edac@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx,	kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx,	tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx,	x86@xxxxxxxxxx, hpa@xxxxxxxxx, luto@xxxxxxxxxx, pbonzini@xxxxxxxxxx,	seanjc@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, jgross@xxxxxxxx,	ravi.v.shankar@xxxxxxxxx, mhiramat@xxxxxxxxxx,	andrew.cooper3@xxxxxxxxxx, jiangshanlai@xxxxxxxxx,	nik.borisov@xxxxxxxxDelivery-date: Tue, 28 Nov 2023 10:03:16 +0000List-id: Xen developer discussion <xen-devel.lists.xenproject.org> 
 On Mon, Oct 02, 2023 at 11:24:44PM -0700, Xin Li wrote:
> From: "H. Peter Anvin (Intel)" <hpa@xxxxxxxxx>
> 
> On a FRED system, the faulting address (CR2) is passed on the stack,
> to avoid the problem of transient state. Thus we get the page fault
                                                ^^
Please use passive voice in your commit message: no "we" or "I", etc,
and describe your changes in imperative mood.
-- 
Regards/Gruss,
    Boris.
https://people.kernel.org/tglx/notes-about-netiquette
 |