[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write

To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Thu, 23 Nov 2023 10:52:02 +0000
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Delivery-date: Thu, 23 Nov 2023 10:52:13 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Stewart,

On 22/11/2023 14:46, Stewart Hildebrand wrote:

GICD_CTL_ENABLE is a GICv2 bit. Remove it. The definitions of
GICD_CTL_ENABLE and GICD_CTLR_ENABLE_G1 are identical, so the value
written is unchanged.

Thanks for spotting it. Maybe we should move GICv2 specific definitionsout of gic.h. Anyway, this is a separate clean-up. So...


Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>


...

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall

Follow-Ups:
- Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write
  - From: Julien Grall

References:
- [PATCH] xen/arm: gicv3: clean up GICD_CTRL write
  - From: Stewart Hildebrand

Prev by Date: Re: [PATCH] x86/HVM: limit upcall vector related verbosity
Next by Date: Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write
Previous by thread: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write
Next by thread: Re: [PATCH] xen/arm: gicv3: clean up GICD_CTRL write
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.