[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device...


  • To: "paul@xxxxxxx" <paul@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Wed, 22 Nov 2023 22:50:59 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fu6XQbDtjyOpbQ5xLRtKKFWfHV+6B+hlHG+VdzqjaKQ=; b=X1eO6yT6kdNCo4oo122VRA/E/a2CCEH4/1gWrPsdPjZ3Tm89zPfCQUMVXExb8WdvNDAdXBnCtiLRxpNauWRjjMU8iGrJjvTEP3mc3965CcON5iFJS6XcbuTAmi9eoWiGsycmSgUFvfkffdkL7ooglUiz46wq+WH+M0s+L3hfsSOoCpq8SSNfYZRkImKQ1RHLDZphwtYeJ1Lec5INt04cau2VIRqTVeMQXOKTto91QNhQ2FKwOEMVJmA6uqZkVr2bpeDWzK3KkJ6wlBz3xpFuA+0dASo3LrT5F+dMweXDSriDbE3xQo0kSde4HjFn4rVFjjkVtxUV8e2IltDOorSbfw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpCr3EcZzWgvT3Sy7H6nx7eSIVDMAHC0wFXIHNa3+MbpjiALJtFxh0MkMwt7GRgij2XwI9L4o8VNlwHnBfh+XrW52RXxg1fsq87UNem9fCJ4kTN2AUegLBB1SQkPN+Swn7fTGNWRjLJHapiT4dbmDnx/zG01j6C/RhiaeTnA5vu2SRJ2YyXOs7z7vlqbyOK3ZUbIWeCRvQ0zxo1hwHkNSuwg/POqReHKJyJa5lJhs8jo9hagbVOPx72PrFkbN4UgT5JVIXav1icbqS7cHTOM45DqTFb8kDGQfv7bRJLYNcAiMUC+iW4tIgDhuR0OSEoI7SLc3wHHVWVCLyMFdEq5NA==
  • Cc: "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open list:Block layer core" <qemu-block@xxxxxxxxxx>
  • Delivery-date: Wed, 22 Nov 2023 22:51:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHaHMeI7KczK4z02kGE/beB6udNwrCGkgaAgABg54A=
  • Thread-topic: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device...

Hi Paul,

Paul Durrant <xadimgnik@xxxxxxxxx> writes:

> On 21/11/2023 22:10, Volodymyr Babchuk wrote:
>> was created by QEMU
>> Xen PV devices in QEMU can be created in two ways: either by QEMU
>> itself, if they were passed via command line, or by Xen toolstack. In
>> the latter case, QEMU scans XenStore entries and configures devices
>> accordingly.
>> In the second case we don't want QEMU to write/delete front-end
>> entries for two reasons: it might have no access to those entries if
>> it is running in un-privileged domain and it is just incorrect to
>> overwrite entries already provided by Xen toolstack, because toolstack
>> manages those nodes. For example, it might read backend- or frontend-
>> state to be sure that they are both disconnected and it is safe to
>> destroy a domain.
>> This patch checks presence of xendev->backend to check if Xen PV
>> device is acting as a backend (i.e. it was configured by Xen
>
> Technally *all* XenDevice objects are backends.
>

Yes, you are right of course. I'll rephrase this paragraph in the next
version.

-- 
WBR, Volodymyr


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.