Re: [PATCH 6/7] tools/xg: Simplify xc_cpuid_xend_policy() and xc_msr_policy()

[Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>]

Hi, while rebasing with something else I noticed that...

On Tue, Nov 07, 2023 at 03:49:20PM +0000, Alejandro Vallejo wrote:
> Remove all duplication in CPUID and MSR xend-style overrides. They had an
> incredible amount of overhead for no good reason.
> 
> After this patch, CPU policy application takes a number of hypercalls to
> recover the policy state and then those are passed to the xend-style
> override code so it can avoid them.
> 
> Furthermore, the ultimate reapplication of the policy to the domain in Xen
> is done only once after both CPUID and MSRs have been fixed up.
> 
> BUG!!! apply_policy is sending the policy after deserialise when it poked
> at it in its serialised form.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> ---
>  tools/libs/guest/xg_cpuid_x86.c | 261 +++++---------------------------
>  1 file changed, 38 insertions(+), 223 deletions(-)


there's a blunder in the commit message. This was a note to myself to fix
something while in mid-dev, and I did, but then didn't remove the paragraph
from the commit message.

Obviously those last 2 lines before the S-by shouldn't be there.

Cheers,
Alejandro