[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 22 Nov 2023 15:49:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQRbVzVpwk8rv532XHLH7JbjbPGzTCtp+bSvWpzmbPA=; b=hbNVSF5I8T+0sXbefkHc+Wou6laulNDC/XXzoimsF1D5EEWRNwhJlynBxxy3h+ZLbNYskhGkkdtUzfghPdvTfWHsu1TsLTxMW0t005jjcHUO41DQYF0E30Xr6zifyTxpu3QjxWdOBMXXK+mmOxa7xuOiMHfQkAtzTTsRejL2iyVhhU3xDDHivCdg9LN0x1yARHx6zjbQnGmQxBayKZH/AyCe7d45K3/w7TqmNIu0W1XsWeY5SdCOFMZBxNAWqsmvt7mms43dF7iQTX4Do8jyTwZSPQkgQVu65uucRjPpoFJ8vqiI6+CAJocB+QlJRsethzJn+TMwYjSmFFpsr1WRqQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LQRbVzVpwk8rv532XHLH7JbjbPGzTCtp+bSvWpzmbPA=; b=E/sHO2BNufbvrFp6MI2cl6DojnGptgwO8uflZKLzq7XmtBpQs8hmPOYExvm01lSWNSHXogZX5wa8jKcl/Us2n0ycMEThfnyjK3xU2W3LhnS3bFK5Knt2sQiq8ofMEt3yzHY2WPcbctHOUy/Ec2vPLWNIRuFHlUPxrSYo+ZfDglviOYNpyvQzeDxoujrCjZSP1/ah+55fOcoKyx0fmlVH59fO9i3gw+F48b7RBcoIxlPY7KdrroMEpPOJ3MHIIYxDm2VkiodoBDmgkDJtLMGL16aJz/W9XWLR9qsraNa8qhmEv5GTstTUCy5KkxHrP6MP+bkZPB5nMQ3NPhFNpPwANw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mj8lEYuGmdUJ5t2MfRXXE76qz4rR24vHvj/QskukTgQR/xHFRfccbfQxD61urRwmx1Swjvn0NZfu3gsImGfynWY4NML47qXlrm72EyX7tIbwhJM5vCYXQYanfSgLQktLFxz1WHPP3Ymw6vZ3UVHeq0quHrKjoglsr6KOivshqQDVITqNbCJHnjYPl+MAhYeH3bpW4OyTjunO/zHItvX/OYH3mJW3HNQ4EKHrZVmwp9mOPIDpm0NCJ+hT3lZbx/9AiXMbxaUyVcSqo8ogOnWQX4GFqNRB8Y1DxQO45Yb3usY7n693jorR9bUrCIfQPoEhcxnnW29Lhl1SFaR36QXmyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVPtiG9sB6wcOT60QuWTKkx+5burEDTJpnv4GDFDnp2S4putbqOymZqya8KcFoTzvlpLB+U2zkXvqWa1GBpq3ezpE3ANQqmKC1/HGaMnKXFbBPlz6SN2myRnk7wpEqKylugr+3OTu0EQbB3xJaLs4za2L4qk1dgQz2EMVJGvq9BWPysISXqJivWlf2LcV/MVLEtZHxSrh+hHukb3i9scYV8iLOpTBRCYCH+Aw2HV7Kycrp3N/yrnwLo3uhEBkSqDyPoKnkIttzARDmvcvNwjjgx9RiybX86bSxQbJcOeX11gi9eqMVUlKVdMclpq+F4m1Gekp/0a2qX64h7cRNAceA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Wed, 22 Nov 2023 15:50:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaHLkYgzDzOjzraUK+7wQZW0TenrCFOoGAgAACTgCAAUCpgA==
- Thread-topic: [PATCH v2 4/5] arm/efi: Simplify efi_arch_handle_cmdline()
> On 21 Nov 2023, at 20:41, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 21/11/2023 8:33 pm, Luca Fancellu wrote:
>> + CC henry
>>
>>> On 21 Nov 2023, at 20:15, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>>
>>> -Wwrite-strings is unhappy with assigning "xen" to a mutable pointer, but
>>> this
>>> logic looks incorrect. It was inherited from the x86 side, where the logic
>>> was redundant and has now been removed.
>>>
>>> In the ARM case it inserts the image name into "xen,xen-bootargs" and there
>>> is
>>> no logic at all to strip this before parsing it as the command line.
>>>
>>> The absence of any logic to strip an image name suggests that it shouldn't
>>> exist there, or having a Xen image named e.g. "hmp-unsafe" in the filesystem
>>> is going to lead to some unexpected behaviour on boot.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> ---
>>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> CC: Wei Liu <wl@xxxxxxx>
>>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>> CC: Julien Grall <julien@xxxxxxx>
>>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
>>> CC: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>> CC: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
>>> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>>
>>> v2:
>>> * New.
>>>
>>> I'm afraid that all of this reasoning is based on reading the source code.
>>> I
>>> don't have any way to try this out in a real ARM UEFI environment.
>> I will test this one tomorrow on an arm board
>
I confirm that booting though UEFI on an arm board works
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
