Re: [PATCH v2 2/7] automation: remove com1= parameter on QEMU smoke tests

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 21 Nov 2023, Roger Pau Monne wrote:
> The serial is already setup by the firmware, be consistent with the rest of 
> the
> QEMU tests and don't specify a com1 setup.
> 
> Note it's also bogus, as the extra ',' will make the intended DPS argument to
> be parsed as the io-base.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

> ---
> Changes in v2:
>  - New in this version
> ---
>  automation/scripts/qemu-smoke-x86-64.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/automation/scripts/qemu-smoke-x86-64.sh 
> b/automation/scripts/qemu-smoke-x86-64.sh
> index 188ff8e3d658..3014d07314b9 100755
> --- a/automation/scripts/qemu-smoke-x86-64.sh
> +++ b/automation/scripts/qemu-smoke-x86-64.sh
> @@ -19,8 +19,7 @@ set +e
>  timeout -k 1 30 \
>  qemu-system-x86_64 -nographic -kernel binaries/xen \
>          -initrd xtf/tests/example/$k \
> -        -append "loglvl=all com1=115200,,8n1 console=com1 noreboot \
> -                 console_timestamps=boot $extra" \
> +        -append "loglvl=all console=com1 noreboot console_timestamps=boot 
> $extra" \
>          -m 512 -monitor none -serial file:smoke.serial
>  set -e
>  grep -q 'Test result: SUCCESS' smoke.serial || exit 1
> -- 
> 2.42.0
>