Re: [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str

[Julien Grall <julien@xxxxxxx>]

On 21/11/2023 17:00, Michal Orzel wrote:
> Hi Julien,
Hi,

> On 21/11/2023 17:09, Julien Grall wrote:
> > Hi Michal,
> >
> > On 21/11/2023 09:45, Michal Orzel wrote:
> > > At the moment, the 'hex' string is placed right after the 'putn'
> > > function in the .text section. This is because of the limited range
> > > (+/- 1MB) of PC relative 'adr' instruction 'putn' uses. Modify it to use
> > > 'adr_l' instead (range extended to +/- 4GB) and move the string to
> > > .rodata.str. This way all the earlyprintk messages will be part of .rodata
> > > and the behavior will be consistent with what we already do on arm32.
> > This will be correct today, but I am actually thinking to move 'hex' to
> > .rodata.idmap so it can be used while we are on the 1:1 mapping and/or
> > temporary mapping.
> So you are planning on extending your series to also cover arm64?
It is not in my soonish plan. But you are arguing that this patch is for 
consistency with arm32. This will not be after my series.
And I would not change arm64 just for consistency because I don't view 
it as necessary. The boot code is already not the same.
Cheers,

--
Julien Grall