[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/arm64/mmu: head: Replace load_paddr with adr_l where appropriate
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 21 Nov 2023 16:31:56 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHPfD/1DF3FkTM9MqpRrTxtfkT7bLAM9o/SymS0IXEw=; b=J4ffzWddGN0Qt3VDWIc/13Atl+sThAooWtdICOp8iutsra9VFajaaKj8Pf1fy9BVhi8r3YxDk3Cd3mWjfBYGOx40ZKJ4wHu9/1cA55c5y7K0IM+1hcFtm1GwJG0TeYk0U/8ZZ2Mqwa5nSRF9HExFyJB/Iqpl/XDxdw/Gw3WQLk/zFrURnInaVVce5aBVxMGhocaZRX0LmsUojYynfX5vE0CfSte2VRQ1RJo0HL1YaIzk5HZ3Rqf9loyyuPeLr8VS7A3SbebPh3zKvd3BDfMTMojDAXCneFPtIv2P0zzKwXlpwDXox9O27MRNRuXpSedewRhCH+XRMh+XsjWVDjQOMQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHPfD/1DF3FkTM9MqpRrTxtfkT7bLAM9o/SymS0IXEw=; b=B5jkYZoPHWVUIgF1D160jaG/R2BWwxOYko6Avf50aL9ziavdXTam7+r+0yEVMdQE+PIu5tshUyjWSG7DGHzQLBXjHiKE/bDv+5mLPkapMjGt5WTPqFhvd4n0NoJSFG7LkC6V28dv//tuQC+EShls2lTBVthF+mz++ms9XcgArAJI9Ku3r974EZGh67kvOtysbKNjS30EVctiUKQ7vq55FFBDzQk6QuB/pP9wkwwSulIYNfV+MLEwhEAC2OOlzMJKkr9o9weMwVyCWm07SWfajOTajIRwaDrZ0CEJsmpQAYz/lU/h4PtZOVofGqgBKs1sLG387AwMFnWk4hnLT6jNoQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XkrdOo1bRgEeOp6nTbevT2sI3mJIuPYkZxHX+FGh/443j1FN3uKcQKbcgK0vddf9FButd9lWzle/p9q14bNCeK5D5oe3y0fDSa/r9fy+0NvGhQDyNwoZszzkA9mxQ/OPWAGyB65VigfAN927Z4f4zWmwm2x8374Hn+6Kw17npaN1VK0kcKlB9S43I3Aeje1cXV5yoli6Ktc3P7SYTGclJ8furWC4BbZid48tjFgjcaZ/WO/l7zlOxAWUjJGIb7Z+wUmRz2RcVvE4E40l1lGWZ3w+ZErJg7q8p0McPfYx5n8tjlzmb94MRTg/NS5iiOhTAlJrYkQUV1MVQopZUuQotw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWXRm4dcvaELyjZxqcGimldyhFWga8IagQC/UYYkJqArq1LyNXORi0Kz8b6FiTSXJpZqngmN7a/YdC8MKZGbyd6sMA0Yf/S8kaZZK5KfJC0sOF9SmjOJjeJdu3O+fs1uvBZ5mIPAtw7HCOlqmHWCl6TUmjKYXy6SVt7eXrm5auPyb9OKtuDQZtZfn43fitLNkspeLI7uRb2k5wfOHveMy7xLtW5ehhsomOVnQE1agEo14y/L+1xewiVtTdU+JcBjGR2Ieow3Vb1sps9pcyiS1WRtTO8dyNX8fCnv4AkGX1ZPxMyYdOw3cH00kP9EA9B7ziQOB1ga3QbSqaKy2Rd0Pw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 21 Nov 2023 16:32:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaHF+NDAu4l/eqYUG7NR9h/u0zY7CE97AA
- Thread-topic: [PATCH 3/3] xen/arm64/mmu: head: Replace load_paddr with adr_l where appropriate
> On 21 Nov 2023, at 09:45, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Macros load_paddr and adr_l are equivalent when used before the MMU is
> enabled, resulting in obtaining physical address of a symbol. The former
> requires to know the physical offset (PA - VA) and can be used both before
> and after the MMU is enabled. In the spirit of using something only when
> truly necessary, replace all instances of load_paddr with adr_l, except
> in create_table_entry macro. Even though there is currently no use of
> load_paddr after MMU is enabled, this macro used to be call in such a
> context and we can't rule out that it won't happen again.
>
> This way, the logic behind using load_paddr/adr_l is consistent between
> arm32 and arm64, making it easier for developers to determine which one
> to use and when.
>
> Take the opportunity to fix a comment with incorrect function name.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Hi Michal,
I’ve also tested on FVP
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
