Re: [PATCH 2/3] xen/arm64: Move print_reg macro to asm/arm64/macros.h

[Julien Grall <julien@xxxxxxx>]

On 21/11/2023 09:45, Michal Orzel wrote:
> Macro print_reg is used to print a value of a register passed as an
> argument. While today it is only used from within the common head.S,
> in the future we might want to make use of it from other files, just
> like PRINT(). It also serves as a great aid when debugging.
>
> Expose print_reg macro by moving it to asm/arm64/macros.h and:
>   - rename putn to asm_putn to denote the usage from assembly only,
>   - use ENTRY() for asm_putn to make it globally visible,
>   - get rid of unneeded stubs for early_puts, init_uart and putn since
>     the calls to them are already protected by #ifdef CONFIG_EARLY_PRINTK.
NIT: The last one read as this is necessary to move print_reg() to 
asm/arm64/macros. But really, this is just a clean-up. So I would add 
something like "Take the opportunity to..." or similar to make it clearer.
Other than that:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall