[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Tue, 21 Nov 2023 15:48:24 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m76lJLSH6aD07eGDeHvC7c73SwE8YmWn99suPYmv2YA=; b=cqwpEMiEJb0MWIoLn+GQr21/ud868f+Kow8Rv7dnSMBjOCNW2kbFVRvS6tUDLRhYcCS3napQCl//J+frDyyDF0EGLOc1bqYfo7HuyQzEaghxj+Ckq6WCwiX/J7YdUb9dgv1erltOZIhoODWe2xGV0c3VrD8W6tHm46cU9Xbp+C+mdpNE6nImqPDhRvs4l45jkyHolbJCN1YrWeS5eeN8ANDtClDNh4h3a6AnMwdplMEZQw2GZoJXJVJTtnRzw0ncrEt3M+RRGgSXyvLkLEP0Ysh+4KlvxXqRpbJgieE4mgDpabdd2BPt8MeH00d6la5uNS87/4yQN4yfmnw95xh3fA==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m76lJLSH6aD07eGDeHvC7c73SwE8YmWn99suPYmv2YA=; b=gavrI+IVwhvCMO+zlDYUP7SpTYW7hEksI/lZGFtgFItVo8SXUquwTcgee2qH921WUsvY92Ql4LmN2MvOckoNJGqW/Vqs+c1ROtzzDUJKn8jH9mKEpjlH0c63o+X2ND5LW29zPwDJkTTMO4jbZP3OaFcqpd9fSaPojT3zo2ja/ZPRgHsAnVZWqOZ1CjaWHzOZOkRIuEHrmRTNvv5DoFMWgjt+BFw+gqoCy3wBCxyM6NyEt5uuN3JhErCTB/ppwmOhCkOxHHoY2ZOhYvYOPQ0+Zius+2i0VWaUGcGda3LZvDe9d3SGGbwRLrUgmDRDTU3n1G1Sotap1ktbytRos3AsRA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cq3WOlGJipK+tkvRSdH5FSZ2aOqGW/M8f4XIJV13sieaKcGOKYSpZD5XRUbwQGR/NFNOU5ZeL2Xvhif4JoDxhtm4KnJt6UGvnIDhOGQGyaxZogzxDagffGcZyDkPFMY1y5fmer78JZRQDzICR092y1BonHapJotnRgZHjWBn0Rs9NcMJrdyxZyNTqfWiyIhoGMtLgWTJ3+u7n8zcbih3Jre0ZuqkYf42YnKZCx6XEHjjcMDU2t5J4qL2gBOgulJKjTQBWBCED4ezJFsxSgSOsOkat9oxFQdJt1gFcGQYtGmj4XUwxy216St91QDUtfYx6olL448wvVV3kFaVnWl/0A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzTnzwvlG7XzQR+7sTUk2bfcYSiKaCLBgWNRQmIT+TI4eaVx4+BZxWNhVPbzuu0AUZtDPBcnDCjda77whDDlzJfv9g32+ew9abSo+DY6rZKWIY03sTqz4avvIgSoA6FUErx3TRAtwNlT4FcB2YG7CuthEIVAAEV3cXjhC86aWakM1ecMe8+shExsiO/QV5uDB9eel/EOQJemH8aQKdCAAAJ+WVtrq89428IrFpMrjdb1Ne3H/esojUsTiir3yujPYKK/eaN8Qb0FTyZjyk8y0Kof0qowFPVz0Z87ywsR0pyGpSpRw1c3+aTzTrmJBvAldl/1a+gR3Kuvrwt9F3CWYA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 21 Nov 2023 15:48:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHaHF+ZLfO2ZZCzYUW7XLxi+lBn+LCE64WA
  • Thread-topic: [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str


> On 21 Nov 2023, at 09:45, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> At the moment, the 'hex' string is placed right after the 'putn'
> function in the .text section. This is because of the limited range
> (+/- 1MB) of PC relative 'adr' instruction 'putn' uses. Modify it to use
> 'adr_l' instead (range extended to +/- 4GB) and move the string to
> .rodata.str. This way all the earlyprintk messages will be part of .rodata
> and the behavior will be consistent with what we already do on arm32.
> 
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

Hi Michal,

I’ve also tested on FVP

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.