[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/5] xen/arm: Move static memory build code in separate modules


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Mon, 20 Nov 2023 08:49:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4AuotxSbapKYbp98PnuCWjuafLs1kWLuSEFZvD5mdso=; b=FmtlZN0GlM3cRtnMz4Qcm6JdtPFJ7BQGoxIeYdCe0A2TkYr2CWVe9XCcZrsVjhfjqunrwpya9RLZ68Ha3P+YoxHpfffTs0KoaYyiyvKOJ3a/5HJcIzx0kCxg7n7lX3/5ogOG/wsWtQVYWpC7hEa2dKQroqYrASTdBIH/4csfVxPFv9D7h5WghIZkawhulTOh1U1I7NfsquxU9VNOJH+/eGrwk2aC0x2DAgFot0GFL49f4vIaVHd6cQ99nQoq0BRimktohWlBpH4128Xcy5zdKGPwow6JWPdgyuzji8f5ISyQRf3wjAUce92e6JOSuiUDOwMFTSKPYSpbpRW90vJzsA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EU7XJ85k+y/AOAC6d1450cZkGxuvubZatieNPeIvJPE7E4jUBupzYkMwJdhmyPWua3kwYj+RrbDRiy14K4Hwz0EcrOYXTvV1JlsjD3XAHLFffa2w1fKYeW8YVc29/SyKgn+n2Nkj2ElBZ+GwLIUXGHRqK3yE/miiKJh4hNpjPg1Dtt0zldcAB7kg0+nfghjLXQEjF3wFMqu2oUcv2AzESJwmxpsoag9kDbRXB4ivLzd/OsdmyhOMPm5299nBq4XVXuiHFLPg4URMSKP7Vce9aTkNNwbsyDIiSIemBtYfTpYSEjYEA9wEWYgT/bos9uvO/O1aFJgGxBXF+Yn+VFM+SQ==
  • Cc: <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 20 Nov 2023 07:49:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Luca,

On 14/11/2023 10:03, Luca Fancellu wrote:
> 
> 
> Move static memory and static shared memory code in separate modules
> so that they are included only when the corresponding feature is
> enabled, doing that we modularise the features and we remove some
> ifdefs from the code to improve readability.
> 
> Move process_shm_node function from bootfdt module and make it
> externally visible.
> 
> A static inline helper called process_shm_chosen is introduced, it
> will call the process_shm function for the '/chosen' node, and will
> be used by the function construct_dom0 instead of using directly
> process_shm, allowing some #ifdef to be removed.
> 
> No functional changes are intended.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.