[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci
- To: Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 16 Nov 2023 10:26:38 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2cefHjYjOV+h/LZVsktYOyroyJEyrlH6VzZsfmy8UtQ=; b=aOoZFlyAcukCqLDh3+0JDpKtf12WpUbsduhsCuIXo87q56XSGLnWOL8p7svkl9bDJsjAsl6INHDav81wJtZhEU2oAS/aaiMswKflYmtriIkxjKhOdTCSpuAsUY7+E4onPpyqt+iMWE+3hfg77gBwQ2RZJ77PsiDkoRV6Fu6w/Q2l6lmwK4cg+3RuvVEcWYKM1z6DnPorIIlMruFHI0fFoE7c9P5/PVie9crXSGoQuLpmFX/cqDRFa2MXQKj+9645S1oo1vSZ7ZwJslyyff8Os+z3qWe0hfKQG6zHWrfPPtmoVy/Y4MFR4kf6F/cMBRn+amvSbDlcM0dQw71diWhajg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYC+soGsVm3R6cO6dwbB3yfjQo9KblIjECq4MDdYkDmSe8RxfZFpWIyH0DZQ0PNhZArKkPOO1F84bigwpjHgzQYCVRZsPYp22Ul+PAcr58aFEkwnPKyiQW4Af2UDZE6qticOUVrYRTGElqIqo+KKtyqsrZT6WpHsHEaDCz/LsHVlBzdaq/Ux8VqNHCB3xMD/hdY18+ABG1AQsO/Xhv0tYrUDEizq+PKqNKEmpUmLIea5n8j6LBPpiF3pb1XirpMNJT/RNFagKtAdpK5s1DsVhosE52YdcM+jcRcL4uhnsbrd2Kh5MMTgBAORX7SqirqY5YLIWcYZKn8zimqErkiVlA==
- Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "vikram.garhwal@xxxxxxx" <vikram.garhwal@xxxxxxx>
- Delivery-date: Thu, 16 Nov 2023 15:27:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/16/23 10:12, Julien Grall wrote:
> Hi Volodymyr,
>
> On 16/11/2023 15:07, Volodymyr Babchuk wrote:
>> With my vPCI patch series in place, hypervisor itself assigns BDFs for
>> passed-through devices. Toolstack needs to get this information to know
>> which BDFs are free and can be used by virtio-pci.
>
> It sounds a bit odd to let the hypervisor to assign the BDFs. At least
> because there might be case where you want to specific vBDF (for instance
> this is the case with some intel graphic cards). This should be the toolstack
> job to say "I want to assign the pBDF to this vBDF".
Keep in mind we are also supporting dom0less PCI passthrough.
>
> Do you have a link to the patch adding the logic in the hypervisor? I will
> comment there as well.
See add_virtual_device() in [1], specifically the line:
pdev->vpci->guest_sbdf = PCI_SBDF(0, 0, new_dev_number, 0);
[1] https://lists.xenproject.org/archives/html/xen-devel/2023-10/msg00673.html
|
