Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2023-11-16 10:08, Nicola Vetrini wrote:
> The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced
> by the asmlinkage pseudo-attribute, for the sake of uniformity.
>
> Add missing 'xen/compiler.h' #include-s where needed.
>
> The text in docs/misra/deviations.rst and docs/misra/safe.json
> is modified to reflect this change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> This patch should be applied after patch 2 of this series.
> The request made by Julien to update the wording is
> contained in the present patch.
> https://lore.kernel.org/all/9ad7f6210c15f520297aac00e8af0e64@xxxxxxxxxxx/
>
> Concerns about efi_multiboot2 will be dealt with separately.
>
> Changes in v2:
> - Edit safe.json.
> - Remove mention of SAF-1-safe in deviations.rst.
> Changes in v3:
> - Sorted #include-s and rebased against
> 7ad0c774e474 ("x86/boot: tidy #include-s")
> ---
>  docs/misra/deviations.rst   |  5 ++---
>  docs/misra/safe.json        |  2 +-
>  xen/arch/arm/cpuerrata.c    |  7 +++----
>  xen/arch/arm/setup.c        |  5 ++---
>  xen/arch/arm/smpboot.c      |  3 +--
>  xen/arch/arm/traps.c        | 21 +++++++--------------
>  xen/arch/x86/boot/cmdline.c |  5 +++--
>  xen/arch/x86/boot/reloc.c   |  6 +++---
>  xen/arch/x86/extable.c      |  3 +--
>  xen/arch/x86/setup.c        |  3 +--
>  xen/arch/x86/traps.c        | 27 +++++++++------------------
>  xen/common/efi/boot.c       |  5 ++---
>  12 files changed, 35 insertions(+), 57 deletions(-)
In hindsight I should have added an

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

given that the comment has been addressed in my opinion.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)