Re: [PATCH 4/5] tools/xenstored: remove "-N" command line option

[Julien Grall <julien@xxxxxxx>]

Hi,

On 13/11/2023 12:43, Juergen Gross wrote:
> The "-N" (do not daemonize) command line option is of questionable use:
> its sole purpose seems to be to aid debugging of xenstored by making it
> easier to start xenstored under gdb, or to see any debug messages
> easily.
>
> Debug messages can as well be sent to syslog(), while gdb can be
> attached to the daemon easily. The only not covered case is an error
> while initializing xenstored, but this could be handled e.g. by saving
> a core dump, which can be analyzed later.
The slight trouble is a debug message in the syslog (such as from 
barf()) is often not enough. What you want is a coredump or attach gdb 
to analyze.
For the former, I found quite useful when debugging the Live-Update code 
to replace exit() with abort() in bar*(). So a coredump will be 
generated anytime barf*() is called.
> The call of talloc_enable_leak_report_full() done only with "-N"
> specified is no longer needed, as the same can be achieved via
> "xenstore-control memreport".
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Slightly RFC, as this is making debugging a little bit harder in
> specific cases. OTOH I didn't use this option since years, in spite of
> having done a _lot_ of xenstore hacking.
I have used a few times but when trying to run Xenstored with ASAN but 
this wasn't trivial to use.
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx.

Cheers,

--
Julien Grall