[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] tools/xenstored: remove "-V" command line option



Hi Juergen,

On 13/11/2023 12:43, Juergen Gross wrote:
The "-V" (verbose) command line option is nearly completely redundant
with "io" tracing. Just the time of the printed data is a little bit
different, while the tracing is more informative.

The current position of trace_io() is a bit annoying in write_messages() because it will only be called once the message has been fully written to the ring. Can we consider adding a trace_*() when we are about to write? (Or maybe queue the message?)


In any case, I think it is odd to enable verbose and tracing separately. So with or without:

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.