[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/5] [FUTURE] xen/arm: enable vPCI for domUs
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 14 Nov 2023 09:58:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/uBKZuXL0g023eWHSQWl0n+qwENAapxOUbxZ/kGZDWI=; b=L8j+aE2ncrQAX5vK1FKSSt4d/BeECBe28iqupROZgs8vuJgCbzJf57nXODMYwJXEmlrlGFiLkNYEyxDT1XPXqHAFusCyqpEgFAFuFvmIm4zz1wb6mXyS+efgkdbrElWhfmHdGIQC3IfomW+vu4mFyUP1M3qq+V/QoSw0vqqI8vJ6GUxGAVYDYGkYCuYXuPtI/Xn1Agg2lH8TAY6qjv0reF+PALErP5vB57coWDgEab8Mywnoxjyg8yusnXSrdl1Giklw7zioXctv/c9woi4j/N5Nysr1UI/JyUYkZlTsOLy4WkIrs+CT+ZPM8valWHz7Ata9Udrm9unPZMiALLHN2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVjz/NRQYGzdSXZmF2gFO/Hd5eg6tnksOHpWuKzoSmd9rrdbCGucHJJsTNPYc0lNH8P1n4rfGc5Xr9nh4vOcnt6ycR7B6OrbizcryeRZ5cPCciaERun49GN25HVaoNYAPd/5XvhagM8V8imgVse2jSDlyFXOJqxfogq4SX3cBjyTFNkL8mhC42qP/QxbRviT/DnXhNDb7QkQXZ7ap899jhd7ee5/Sj9NcnB9tI0upS6aDJJPmSaZIkRml753C9rCVcVSGZ/eav7tsUyV1kAM95e/Bpnaf2A9TVWU72NpO5yyhS9QXsY27FGP172FJoq7dViya+KRwNnfP03aLHuzNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 14 Nov 2023 08:58:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.11.2023 22:10, Stewart Hildebrand wrote:
> On 11/6/23 04:26, Jan Beulich wrote:
>> On 02.11.2023 20:59, Stewart Hildebrand wrote:
>>> +/* PCI passthrough may be backed by qemu for non-PVH domains */
>>> +#define arch_needs_vpci(d) is_pvh_domain(d)
>>
>> Wouldn't we want to check for exactly what the comment alludes to then,
>> i.e. whether the domain has any (specific?) device model attached?
>
> This patch is primarily dealing with Arm, so I'm considering simply making it
> return false for now:
>
> #define arch_needs_vpci(d) ({ (void)(d); false; })
But that's wrong for hwdom, as much as - strictly speaking - needs_vpci()
returning false for hwdom is wrong in the PVH case. This would then at
least need clarifying comments.
Jan
|
