[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/15] xen/asm-generic: introduce generic header iocap.h
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Nov 2023 17:48:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6JRSdqBHeEkCAFq4486nRARdw8b/aSBwq/+1n4Yju6o=; b=FHIfhTT1wAZP8xtDMjrIlT6z1xTVqd17DsHxjZEICVDk0o67QsmbmfiLMDb/m2TTY+YwOpb5oCkLYr8IEdc6//nVGTvwpwaiba4PYlQ8HYrC3nvl9rZIbaEYdNUozvm8dL9GJiJDp76t/FvdEX2wVZjLSf099kh1HUGBx0YUCaioqYzi+WjXLL4vUlFlhT7dhUpKflTWCPQddvuhKQaxlDFSOb8hXyNrZJteeuT8s4rBgJ0ZtQwTaJiPg0HUt0OmGzaZb74YfudspI7s3H+qfXHa5hJkzj1bAl8xScsTHp3QSydBEm2ZJmllQz0tvMDQ/JYpU7bjAhdGip/tGOkqnA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gVTILsWzWacJZE0iRO1eQAszenPr+WROx4G0nglT3axn1sR6thM9K6KlnwP/DScPN7o7xvln61T7FKMcF4Nn8etQtKD3g1TTwcrDmYEGCftJODI3dcpgi5H6XKRQiHnQKgy0DsWkST74F0eFvu7vIqj5EbM9ktFfVp1dXkHKRTQ3IsIFCx0W88pUgfcXzRUITe6iyRjz9wy/bgUhfopisKPOeAS7iCYCbpmuij1ROuQZAmaERImr6IpISxyhP8U+oa+Tgyk/SGXvKp8+vZ85fwZmhbMaEggMVyf33MTrp3ca1Brl31ByOT1iakq9N4rqNYx5meiCge/1ERadvrdPWg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Nov 2023 16:48:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.11.2023 17:30, Oleksii Kurochko wrote:
> iocap.h is common for Arm, PPC and RISC-V architectures thereby
> it was moved to asm-generic.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> The same question as with device.h. Should it be in asm-generic?
I think it's okay(ish) here, considering that ...
> --- /dev/null
> +++ b/xen/include/asm-generic/iocap.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_IOCAP_H__
> +#define __ASM_GENERIC_IOCAP_H__
> +
> +#define cache_flush_permitted(d) \
> + (!rangeset_is_empty((d)->iomem_caps))
... the only thing referenced (iomem_caps) is a common entity. And
again Arm demonstrates that an arch can get away with just this.
Jan
|
