Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of <asm/mem_access.h>

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

This patch should be reworked as it fails Arm builds:
https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920

It looks like it is not possible just to #ifdef CONFIG_MEM_ACCESS.

An empty asm-generic mem_access.h will be better solution.

Could you please share your opinion?

~ Oleksii

On Fri, 2023-11-10 at 18:30 +0200, Oleksii Kurochko wrote:
> ifdefing inclusion of <asm/mem_access.h> in <xen/mem_access.h>
> allows to avoid generation of empty <asm/mem_access.h> header
> for the case when !CONFIG_MEM_ACCESS.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
> Changes in V2:
>         - add Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
>         - update the commit message
>         - remove <asm-generic/mem_access.h>
> ---
>  xen/include/xen/mem_access.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/include/xen/mem_access.h
> b/xen/include/xen/mem_access.h
> index 4e4811680d..87d93b31f6 100644
> --- a/xen/include/xen/mem_access.h
> +++ b/xen/include/xen/mem_access.h
> @@ -33,7 +33,9 @@
>   */
>  struct vm_event_st;
>  
> +#ifdef CONFIG_MEM_ACCESS
>  #include <asm/mem_access.h>
> +#endif
>  
>  /*
>   * Additional access types, which are used to further restrict