Re: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi,

On 10/11/2023 10:30, Luca Fancellu wrote:
> 
> 
>> On 10 Nov 2023, at 09:05, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>>
>> Hi Michal,
>>
>>>>
>>>> +config DOM0LESS_BOOT
>>>> +       bool "Dom0less boot support" if EXPERT
>>>> +       depends on ARM
>>> You're in the Arm Kconfig, so there should be no need for this dependency 
>>> (it is implicit).
>>>
>>> Apart from that, we have 2 features: static mem and static shmem that are 
>>> only meant for dom0less domUs.
>>> Shouldn't we make them dependent on DOM0LESS_BOOT? Otherwise, what is the 
>>> purpose of selecting them
>>> with DOM0LESS_BOOT=n?
>>
>> Sure, I’ll add the dependencies and remove the ARM one
> 
> Just to be sure, is it what you are asking?
See below

> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 0399f2faf734..d9c5340ff3a2 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -90,7 +90,6 @@ config GICV2
> 
>  config DOM0LESS_BOOT
>         bool "Dom0less boot support" if EXPERT
> -       depends on ARM
>         default y
>         help
>           Dom0less boot support enables Xen to create and start domU guests 
> during
> @@ -214,7 +213,7 @@ source "arch/arm/tee/Kconfig"
> 
>  config STATIC_SHM
>         bool "Statically shared memory on a dom0less system" if UNSUPPORTED
> -       depends on STATIC_MEMORY
> +       depends on STATIC_MEMORY && DOM0LESS_BOOT
no need for && DOM0LESS_BOOT

>         help
>           This option enables statically shared memory on a dom0less system.
> 
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 4d6fe051641d..e0e5f4485d1f 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -100,7 +100,7 @@ config NUMA
> 
>  config STATIC_MEMORY
>         bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED
> -       depends on ARM
> +       depends on ARM && DOM0LESS_BOOT
no need for ARM. DOM0LESS_BOOT already depends on ARM.

~Michal