[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 8/9] xen/arm: enable dom0 to use PCI devices with pci-passthrough=no
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 10 Nov 2023 09:53:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+uwS8EQ9CkcWH+n9KkBP16NPb+wt9gGIoA9Hvva+wVs=; b=EksbzfQMBnAoeTpgEhkYR9kBwmUT4LOmf4dRGxRPoxsPn2wgr4LyPmCqDi2ucj0OfwJK2TBIFdvPljR0asUvZeRDiCzpIzl448WzsTvW0WQ0gHR69gMRD5ULMCIDO3hOIXi+MoO1mU1pi2288SRmflLLH/sJho5mXU9aMUZ5AwJy+IIsDx6GyrvqKbsS9cnS1B8VK4jCx8SBu9f73i8bjspfy2TBAd+KDxGESUgGyhoYj5xVQCJ1JhtreMQOxXLhm0VUw+6+7QPvDbKuewUrlboxr0zyt4qL71p0Zq2y02Demxfoae/fjnaAt6e6d8LaDWjxTYXbzrFBmlNV3CUTwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0MDxaTmCTuAKknKEW7lhauFvb2VtCvTZMv649XWL6bXrhlh0TNMnABtxr6Fy5KBoi0AmCfFbxGLdFlCRsRilKqK7+2K9Y1NVi+92dT+j/Me4iumUtd4TAdHN4HTbi6MiDFxadiktxofH/sAuYpV0ujclSDRJmAyC33sVvj8Fw50LQH0+roTlZoToeFdPK50cyKAMrVRctSEJeJnAuxx1yTNoGFAilVHO8wMjrr2mNcQu35SkAzwSn2vxINy3AsiFz3IH+bviwafZIOpI5E4rTw1ulIXqaGEaJyxWSM0DzWGxEgbjksfQxh6ujdPiLch8FuMYUAOGKLVYXT+wgOu6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Nov 2023 08:54:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2023 19:27, Stewart Hildebrand wrote:
> --- a/xen/drivers/pci/physdev.c
> +++ b/xen/drivers/pci/physdev.c
> @@ -18,9 +18,6 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
> arg)
> struct pci_dev_info pdev_info;
> nodeid_t node = NUMA_NO_NODE;
>
> - if ( !is_pci_passthrough_enabled() )
> - return -EOPNOTSUPP;
> -
> ret = -EFAULT;
> if ( copy_from_guest(&add, arg, 1) != 0 )
> break;
> @@ -56,9 +53,6 @@ ret_t pci_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
> arg)
> case PHYSDEVOP_pci_device_remove: {
> struct physdev_pci_device dev;
>
> - if ( !is_pci_passthrough_enabled() )
> - return -EOPNOTSUPP;
> -
> ret = -EFAULT;
> if ( copy_from_guest(&dev, arg, 1) != 0 )
> break;
This renders is_pci_passthrough_enabled() and Arm-only construct. IOW the
x86 definition of the function should then also be removed, for ending up
dead otherwise.
Jan
|
