[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/5] xen/arm: Move static memory build code in separate modules
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 9 Nov 2023 15:34:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m3eXTsVsY4QZ48T4C22IeeOy/fXf/zPA1j8gxc0ySaQ=; b=nZE7ZvCjLLD1kXokFWs+b7hkTGqVsFGs1GYzNChw1VZjJV8eUu3M16fnhCSpEttfEorAdS0vEyAvebV3KjGcDVE3/iaVHqxTZ+kFR+5/41e3XMKkyrH40IOfnm2J2ln8akoehXKdEk7oapEfYFFnWssOXq38+UQEWqeXrFItR27MYIhazTWb07vi14t1mUzVKyrGfy3zMdWZFjnfjFYN+q/TVZPh+e3+81QKRcT2pQxh3O/e4VcBZDtP0DavEzKzzP1FSlWemoUkdpqI7lFtBlX8/d4+u3+d2viG43ryNQQowCJ4VhK+Ij01jmKxRYyI0OTc23d5bXkeooEIjh7UuQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m3eXTsVsY4QZ48T4C22IeeOy/fXf/zPA1j8gxc0ySaQ=; b=Ey8nfoMnJQ2MWozOYeaoQFelMezeSFxtWoNo4UYNCdjVZPqTDUqbyQAJ7c9UP1ldijt+UuUtzqIYotUWfAqRybOKp2SLnef6RHUUjAzn3TAu3KA9cXSnfKVTH7k8DlJRW0lTvh7dVZb2eX6/iVAr8XqoLcPOKrr02qLFKsJgXU9wbneDHYWsZe8ZxHApDVMcy5mSXvvHHzn58u0t5SQK5cx61yb3D0V6dpdDwQQVvJIgOp+N+0wDgTGVQnThyGuo4lWbussrTfQOq7gdRV0dVK8CE3XxH3OR58hmJCe9GGpi7IA+oVuLYtW1E+DIEqYnueMEI8vOXUvSjQ2HGiVLcg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YWnosif68JtEfxYFdPtqctzVSvgdCMLu9AvkqI0651Ldp3lwMzVdk9Coe+MCPvObDdccwpkqMX2pHVXJ5NqLIqGfPHGy5Ubp2KCdwJtWv3UEbnrjzbpbotKGpXtCrQcaT+80Y6PNmrmOWKU9Y0sLcLPugYHBLZ79p2D4rPhGdIbv4Ww5tW00aEgemCFHN1PofmhhON3uY0BhgoJzX5KlQKiDWSNJWrpSpO3chucgOF5j1Ujs47rsFa7NRhb+EfqPxyoS+xUXD6Enk4dIOU6bYL4cp4lSByzreCjqAl6XkIuquVtP4aCZ7JxQQPVIVLzh/piY6XaVOUIZmedotCpiBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKUzpYGr791q1ycs9Tb8PDwtQrgAWyU82DLeYC0FAbsivDON/NHz78l1kHQnEsF2NJzWs3Au/awKY3pENzzQLrP8wn1QRUkkbxzsjhqUL3m27pBNJQZtxfzkzHn8BQr4bFLK8PqCEq/+FFdSbVCylgRfoiPc6i+dH61nXnsfDwHG+HxqiXxdTZ9v0TzGlJ+niU4uNjU0hPhbzm9B3CjkUNZ6e33mFX/RoKlOTxhay/6F48NrcW0JumNyQ7UmkMEVY96+qosgPejgE1//zLCEyJTaKOohjvi5BkFrIfRY5thCO3X8Wdqn/5CfNyx//VxKMmJqqR4EtbD6IaH2c+7+tA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 09 Nov 2023 15:34:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEuwaVYEciB6sG06PR543lMQVdbBx1haAgABIYIA=
- Thread-topic: [PATCH v3 4/5] xen/arm: Move static memory build code in separate modules
> On 9 Nov 2023, at 11:14, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 09/11/2023 10:06, Luca Fancellu wrote:
>>
>>
>> Move static memory and static shared memory code in separate modules
>> so that they are included only when the corresponding feature is
>> enabled, doing that we modularise the features and we remove some
>> ifdefs from the code to improve readability.
>>
>> Move process_shm_node function from bootfdt module and make it
>> externally visible.
> What about process_domain_node()? This function is related to "xen,domain"
> compatible that is only present for dom0less domUs.
I see it a bit tricky to do, in fact putting it on the static-memory module
would need to have it
externally visible from its module, but also it needs to have
device_tree_get_meminfo
externally visible from the bootfdt.
I think that one is more a glue-code mostly related to dt and this cross
dependency suggests me to
keep it as it is.
Cheers,
Luca
|
