|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [RFC PATCH 2/4] x86/dom0: make goto jump forward
The jump to the label 'parse_error' becomes forward, rather
than backward; at the same time, the else branch can be eliminated.
This also fixes a violation of MISRA C:2012 Rule 15.2.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
xen/arch/x86/dom0_build.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index 09fb8b063ae7..f0191dc148a2 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -439,12 +439,7 @@ static void __init process_dom0_ioports_disable(struct
domain *dom0)
{
io_from = simple_strtoul(t, &u, 16);
if ( u == t )
- {
- parse_error:
- printk("Invalid ioport range <%s> "
- "in dom0_ioports_disable, skipping\n", t);
- continue;
- }
+ goto parse_error;
if ( *u == '\0' )
io_to = io_from;
@@ -454,7 +449,12 @@ static void __init process_dom0_ioports_disable(struct
domain *dom0)
goto parse_error;
if ( (*u != '\0') || (io_to < io_from) || (io_to >= 65536) )
- goto parse_error;
+ {
+ parse_error:
+ printk("Invalid ioport range <%s> "
+ "in dom0_ioports_disable, skipping\n", t);
+ continue;
+ }
printk("Disabling dom0 access to ioport range %04lx-%04lx\n",
io_from, io_to);
--
2.34.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |