Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Nov 03, 2023 at 04:34:17PM +0100, Roger Pau Monné wrote:
> On Fri, Nov 03, 2023 at 03:10:18PM +0000, Andrew Cooper wrote:
> > On 03/11/2023 2:45 pm, Roger Pau Monne wrote:
> > > +};
> > > +
> > >  static int cf_check update_clusterinfo(
> > >      struct notifier_block *nfb, unsigned long action, void *hcpu)
> > >  {
> > > @@ -220,38 +248,56 @@ static struct notifier_block x2apic_cpu_nfb = {
> > >  static int8_t __initdata x2apic_phys = -1;
> > >  boolean_param("x2apic_phys", x2apic_phys);
> > >  
> > > +enum {
> > > +   unset, physical, cluster, mixed
> > > +} static __initdata x2apic_mode = unset;
> > > +
> > > +static int __init parse_x2apic_mode(const char *s)
> > 
> > cf_check
> 
> I'm probably confused, but other users of custom_param() do have the
> cf_check attribute, see parse_spec_ctrl() for example.

... other users of custom_param() do _not_ have the ...

Sorry.