[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: avoid generation of stub <asm/pci.h> header
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 2 Nov 2023 10:35:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HBgpidQs6Xmle+WD9y+chSEbk6VrmFKVRcQt47E3nJg=; b=UuNPozsxV8aEM9jAOr4qqctDHys5IsAVXnFZnsru9UGfaFyu0aavK+6y+g7GCe9Ylxuq5Pg9LNmfjkeGlVx9TpWPpM+cFeJloqsZWVWUkbtWbCXdJ0b5Tfdfxz7jXxKCFEvmdP5L/vjpCVHOv+QDNO0kAAylfMROqJZSN4vcTEL0c1CSHVM39mlgDB9rBGHRlh356Bx8UT3KmhWgSdVinjM1Rp3POsdffwWOfjcW1Psl4I9Yb/hv0xcGkEsDs0uLFcGpOxBWMeahJcEiqfIydXGtx0je8g6H4lQu+/hFq0BZduwOAEGm4h1Ot4ftZJescBO9RrcyuVjVZOpVAPOkYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJjMfpaNz5E2+B5Y4cZGh8o3SRFCgoQDtj37eE+mhhfrzLVHWVyv6G/WWpvEnpj6UbRx5zIk+fqpzOwMIqguqxqOPb+1LvN61WBgz4z/z/PuIgIm42+BgRZR84G28aL13HZxk+1lhN0cWeHXqD2pUpTHUnkmwI81uPAkcG9mbfEvEwjlgfTQfh2qr/MVSyPc06ixRtg2/wWcs46DwcQy/CLm5tkvEO6B0d0QcJL7VP9Af47vo7Ftt5ZZR7+82COBu5G4dPo9Bjm0/n1VuqOUpGACQsE3PbsTUL+A1QerDgZqh5z8Q1c6cFBxLT7I3jFjhq1XlaQkQL6gw+1dzMIsLA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 02 Nov 2023 09:35:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.11.2023 10:24, Oleksii wrote:
> On Thu, 2023-11-02 at 09:39 +0100, Jan Beulich wrote:
>> On 01.11.2023 11:15, Oleksii Kurochko wrote:
>>> --- a/xen/include/xen/pci.h
>>> +++ b/xen/include/xen/pci.h
>>> @@ -68,7 +68,18 @@ typedef union {
>>> };
>>> } pci_sbdf_t;
>>>
>>> +#ifdef CONFIG_HAS_PCI
>>> #include <asm/pci.h>
>>> +#else
>>
>> This minimal scope of the #ifdef will do for now, but will likely
>> want
>> extending down the road. Even what's visible in context is already an
>> entity which should be entirely unused in the code base when
>> !HAS_PCI.
>>
>>> +struct arch_pci_dev { };
>>> +
>>> +static always_inline bool is_pci_passthrough_enabled(void)
>>
>> Perhaps s/always_inline/inline/ as this is moved here. We really
>> shouldn't
>> use always_inline unless actually have a clear purpose.
> Could it be fixed during the commit ( in case there won't be any other
> critical comments about this patch )?
Oh, yes, sure. I should have said so.
Jan
|
