[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Definition of mfn_t in x86's hvm/grant_table.h



Hi,

while fixing a violation of R8.4 related to a missing include in x86/hvm/grant_table.c I included <asm/hvm/grant_table.h>, since that file contains just the declarations needed by the .c file. However, since the declaration uses the type mfn_t, which is defined in an header not included from hvm/grant_table.h I'm wondering what is preferred: 1. include #include <asm/paging.h> in asm/hvm/grant_table.h, so that mfn_t can be used
  without relying on other headers using this one to provide it.
2. include <asm/grant_table.h> in x86/hvm/grant_table.c, which includes more declarations
  than needed, but has all type definitions.

I prefer (1), but (2) does not have major downsides either.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.