[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] docs/misra: add 14.3
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 27 Sep 2023 09:07:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xJB4N1QRJ3okXLOguvXpjhmLrxJMHq5eAZu6GQCFeZk=; b=Ib2jbWJfwK7+Szb87eecDdm9K/hFyLRxSewOK4LYZ7bk1wjx9we+dwS1a973O3zrtthvvAnjOBvU3jyBgVXR8gD+W/fl42rFj2gb38SCT6SN30Kg8FF9gQrFOa5e4nVGn7bUVD6G6MkR/Lo/l5dztNqucHaEo453FkqNgQH6z5T1FT38Q7gxQhWhCXqvBmEGI2TMvmAdiaCEyYbODBFcYotiV65pvCVfHQBhgHNMDEt6IjWa2OdAuBlxi8uDMaycb+8nXbOCnbXNE2tnZWZPeKt1iGTD5pbi88yqdn820qnogS2A2lKFoYXWr8rJoAu4dx3FqD+qGjSRlodbRVbsFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ED1Je8QaMl8RxRyLYuhcEaqLx3E9JCDSAlO7k6kMB2s7tiQwUR0VCfD/F/qU7/KmjPpKwHEEVDFn66gTVWmEVX6a4VJtEHUweMRR1Qno/y2e0Z/BItYEO1Cr99xquj9gFat2rl0n4ScP9pzPgLvV6iILvBO4MMUl0jWzxUZVCB74og/6DpU2tgOGTXZN+U+ghyKWVKeCrafkII+m/Z2YznWO2xZTYEY3MMtszr2sRMK/a0I/9tkbMiROIjXjBUJcxz9lDJUEnJ091/AbT8SPbszrE7pkFsVZm/E+ujqlQL4yZZBLibCKPe9m5S/ZrOZMHAUzXY31Ki03Gk/cU6BxGA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, julien@xxxxxxx, george.dunlap@xxxxxxxxxx, bertrand.marquis@xxxxxxx, roberto.bagnara@xxxxxxxxxxx, nicola.vetrini@xxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 27 Sep 2023 07:07:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.09.2023 22:27, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>
> Add 14.3, with project-wide deviations.
>
> Also take the opportunity to clarify that parameters of function pointer
> types are expected to have names (Rule 8.2).
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
I'm not overly happy with ...
> @@ -385,6 +386,18 @@ maintainers if you want to suggest a change.
> - A loop counter shall not have essentially floating type
> -
>
> + * - `Rule 14.3
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_14_03.c>`_
> + - Required
> + - Controlling expressions shall not be invariant
> + - Due to the extensive usage of IS_ENABLED, sizeof compile-time
> + checks, and other constructs that are detected as errors by MISRA
> + C scanners, managing the configuration of a MISRA C scanner for
> + this rule would be unmanageable. Thus, this rule is adopted with
> + a project-wide deviation on if, ?:, switch(sizeof(...)), and
> + switch(offsetof(...)) statements.
> +
> + while(0) and while(1) and alike are allowed.
... the final result, but seeing that you didn't get any ack in almost
3 weeks:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
