[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Xen 4.18 release: Reminder about code freeze
- To: Julien Grall <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 25 Sep 2023 11:03:31 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axdkgzcnmGvRCT1eSkQ6qtDz8CiwhIsjf5d6QSt72lE=; b=EbkKe1yTPPJ352jcHc2Aq4YH2QPTM/A6YVAhOdPJ2HqKen6HsBv3cL49sR5s1MXoxDKQcUXksg1YY8VS0ObjPYq7FBsXsBQMts+7vcFhEH0gWK8yQWDLo303+wEyIQrO92EXmXOxiN46tDkSVcxfkSPDfToVMDL5z0up/bkoYjMhdpg+uxvlwepX7Y5RiCsXheXXM3pT/TnwBWTK7r3nQn1+kqLIZJA6sShFo5NOO0ulre0hRDOGyqTPdlTuq24hN/DL1Oy9Fi3zCJqHPItC8OW7+6WuVlkfHtFkNLiR9yiLOYl3FiFTj/aHO6sdFE0K5Y+PUPaoWF7wCRHpkXWRmg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQsyLXDmRxSAu6qj+RtS9HkCtHf7Fm3Sy8M6VE3UZjFxrcMgWmm1eBbVw/mtaAp1SCyIDammJ2cVrkv+zVnltAULaK9WsqsDwaN3TCd40sMC/dLuwMBz0VKE70Un+GhSqAjDUOHe94s2NDZNe5DYisGzB47r3crY0tj8mnLxs3ukcxpAEteGaNMrlh42TIuvkOVZDL4lpXlIQ00vmQL1RrOXAJDQ8e5g17YFtXXb4nftq07efvxFF4LdAiX9Mu/FCmbpmVCibBFLoAfpPkHrdtPpGjb/+1GNncjNCsRc4xdsOw6WNNrgXeySheyuBLlRa8On6hUdg9E1k4x8zEu8Ag==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "committers@xxxxxxxxxxxxxx" <committers@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "community.manager@xxxxxxxxxxxxxx" <community.manager@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Sep 2023 11:04:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZ705Dwyrpd4I60kahQfZlaJ2JtLArFXGAgAACIQCAADDfgIAAGL2A
- Thread-topic: Xen 4.18 release: Reminder about code freeze
Hi Julien,
> On Sep 25, 2023, at 17:34, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 25/09/2023 07:40, Henry Wang wrote:
>>
>>> This, for example, would then likely mean
>>> that all Misra work now needs queuing for after the tree re-opens ...
>> …I also thought about this, to be honest I am tempted to loose the control
>> or at least offer some flexibility on this specific part, as normally MISRA
>> related changes are harmless and actually harden the code. I am wondering
>> if there are any objections from others…
>> Committers, would you mind sharing your opinion on this one? Thanks!
>
> I am split. On one hand, I agree they low risk and would be good to have
> them. But on the other hand, they tend to be invasive and may interfere with
> any bug we need to fix during the hardening period.
Yes, good point.
>
> So I would lean towards at least restricting the number of MISRA patches we
> are merging. We also need to consider a time limit so we don't end up to push
> the release just because a MISRA patches broke the build.
Honestly I am less worried about breaking the build as I saw nowadays committers
normally run the Gitlab CI before pushing, but I 100% agree with you about the
point
that in current stage we need to be cautious.
> I would suggest any MISRA patches should be committed by the first RC.
Thank you very much for raising this good suggestion! RC1(or maybe even RC2)
sounds safe. I checked the floating MISRA patches in the list, it seems that
there are
not so many of them, so I guess this suggestion is achievable.
A side note of this is, if we made the final decision to cut the MISRA patches
by
RC1, we need to finish committing these series by the end of this Wednesday
(Sep 27)
EU time, to give OSSTest at least one day to sync the staging with master, so
that
we can tag the rc1.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
