[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] console/serial: bump buffer from 16K to 128K
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Sep 2023 16:26:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0GbH8bWOJJa1yFfE45qKdFl1iSuGi8m0vptsYPig3aA=; b=Pj+dL8YgoyDOW5Pf3sDARZX8JK+Ar0hp4f8hqL3CaIi018M3svRn1CQFLK/g4NdZCg+wB2djt0sXTOq2f1CyoV88sMhshktGTzYqjHzfiNdq+CQ8o8+qWQQo0ktDfbYRaf41O+sZj757/RK3NV/9G20nWEKIkcfF8Ye/ivexIMBl1HfeE7wChtU0PysVJ6DE3omJwyDah72wu4Y6UHSZQ4lH2J0Bzf33nggalexyKNZ87prcCoW5R1HvNMPGRT8T4z2uD3vDthTs75hTa/ZXzK1CtJuNYduizvmQKRKSGMjZ/NNlYVuXqAp5TG02vYOSSMkID5zvNfTBpfSJwrhrBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FHLbt3PtoOMah0cUsaS/SGePOUIpA0JJNmB5NkCjgnI2o9e8XerRmZpePgnjHztaU4d5W/5hcUqp0VKVtQTsCj8yuTfo4BXS4KZ033vhrzFZqvLVW5xDi2dyV8F+/MOruB2Y30s894qUyOq2XeDOtXYe+i2mKOayQS70EUjf8InOddNrgLM1A/usM5jbQiUyzcRV+P32/czauJ/Mqgh+7d75apxeTVc2NjcTagVlU998OIQJWzz2y+NpPLkHDC45fwpcJ75GzaDnJf+7+vV/z3CVTnsV2UQNItD3tSHL+jbWf7CDGBCco889Tfpqcf0xuccO+r9V0dsz9t9hynkptg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Sep 2023 14:26:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.09.2023 16:14, Roger Pau Monné wrote:
> On Tue, Sep 19, 2023 at 03:06:45PM +0200, Jan Beulich wrote:
>> On 19.09.2023 14:51, Roger Pau Monne wrote:
>>> Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer
>>> being filled halfway during dom0 boot, and thus a non-trivial chunk of
>>> Linux boot messages are dropped.
>>>
>>> Increasing the buffer to 128K does fix the issue and Linux boot
>>> messages are no longer dropped. There's no justification either on
>>> why 16K was chosen, and hence bumping to 128K in order to cope with
>>> current systems generating output faster does seem appropriate to have
>>> a better user experience with the provided defaults.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> --
>>> Changes since v2:
>>> - Bump to 128K.
>>
>> Wow, I was hesitant about 32k, and now we're going all the way up to 128?
>> Even the recent report indicated 24k would be fine there ...
>
> 24k would be rounded to 32k anyway.
>
> I don't think 32k vs 128k makes that much difference, it's still an
> infinitesimal part of the memory on any modern computer. Simply the
> risk of loosing output is IMO not worth us being conservative with
> the amount here, specially if we are speaking about KiB, not even MiB.
Well, I've voiced my view on the underlying principle of this before. I
don't mean to block the increase, but I wanted to express that when I
was halfway okay with 32k, I find 128k excessive.
Jan
|
