[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils



On Tue, Sep 12, 2023 at 08:49:04AM +0100, Andrew Cooper wrote:
> On 11/09/2023 5:50 pm, Javi Merino wrote:
> > This series picks up Marek's v1 from
> > https://lore.kernel.org/xen-devel/20230316171634.320626-1-marmarek@xxxxxxxxxxxxxxxxxxxxxx/
> > Changes since v1:
> >   - Update all containers to have setuptools, as python 3.12 depecrates 
> > distutils in favour of setuptools
> >   - Keep python2's support by falling back to distutils if setuptools is 
> > not installed
> >   - Drop the commit about raising the baseline requirement for python, as 
> > we keep supporting python2
> >
> > Javi Merino (2):
> >   automation: add python3's setuptools to containers
> >   README: update to remove old note about the build system's python
> >     expectation
> >
> > Marek Marczykowski-Górecki (3):
> >   tools: convert setup.py to use setuptools
> >   tools: don't use distutils in configure nor Makefile
> >   tools: regenerate configure
> 
> Two general notes.
> 
> First, because you've (re)arranged and posted this series, you need to
> add your own Signed-off-by line to all patches, even unmodified ones
> Marek's that you've included.  SoB needs to be from everyone involved in
> handling the patch.

Sure.

> Second, patch 4 should be dropped, and a note put in patch 2 to the
> committer, who will use autoconf 2.69 and have a far far smaller delta
> to include.

I have regenerated it with 2.69 and the diff for tools/configure is
reduced to:

 tools/configure | 52 ++++++++++++++++++++--------------------------------
 1 file changed, 20 insertions(+), 32 deletions(-)

Cheers,
Javi



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.