Re: [PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

[Julien Grall <julien@xxxxxxx>]

Hi,

On 07/09/2023 15:09, Jan Beulich wrote:
> On 18.08.2023 15:44, Julien Grall wrote:
> > --- a/docs/misc/xen-command-line.pandoc
> > +++ b/docs/misc/xen-command-line.pandoc
> > @@ -1896,6 +1896,13 @@ This option is ignored in **pv-shim** mode.
> >   ### nr_irqs (x86)
> >   > `= <integer>`
> >   
> > +### no_timer_works (x86)
> > +> `=<boolean>`
> > +
> > +> Default: `true`
> > +
> > +Disables the code which tests for broken timer IRQ sources.
> In description and code it's "check", but here it's "works". Likely
> just a typo. But I'd prefer if we didn't introduce any new "no*"
> options which then can be negated to "no-no*". Make it "timer-check"
> (also avoiding the underscore, no matter that Linux uses it), or
> alternatively make it a truly positive option, e.g. "timer-irq-works".
I don't mind too much about using - over _ but it is never clear why you 
strongly push for it (and whether the others agrees). Is this documented 
somewhere? If not, can you do it so everyone can apply it consistently? 
(At least I would not remember to ask for it because I am happy with the _).
I will go for 'timer-irq-works'.

> I also think it wants emphasizing that if this option is used and then
> something doesn't work, people are on their own.
I will do that.

Note that I will only resend a new version after the tree as branched 
because this is not meant for 4.18.
Cheers,

--
Julien Grall