[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v6 3/7] x86/asm: address violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Sep 2023 11:49:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7JsknStAwn0a1b6zOzfjazy3CyHTY8TZHrEX+Omp/e8=; b=D/pc5vNghYGn4A4uFzhqbxyVroUfVG623aM8cgf3uGVnG/W5oDrrrWYYi0sBbJ/iFEpGKmrFj+J2nPTSeOK6a8Hl+psLYRW7TjZyBt18iBDOzvVCJXeWy68Y363et3Q2IkT7otSvj5osfZ7irwvZfPEOiOTsxw+mr5xKkuFJPZweX/+FUUmOYy2OryzpCx/qSmsMNkE/k2YScJrfVgvw7IlF1AnNYIhT4HxsaZJzGgJnMJU9toN7L7Bmh/47NaQpx/KdtSlLjbVPkJQeoZU7+JFjpC3LeTgE4uQqZltze/OTbYwVZ3QOlJkQeMXUfK7lsdDrGmrb2wOvEy0bSSSCig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MXgb+o9kIweu5tV+7YBl2EMUe/2Q2LXavYFpY3pS2xZHbXaMHv0DQa8T2gvroll4VsVws4nfiy+BW772IVgY1RvNgqj1Bmtd9S2A9PQBCmDs1ht8gJsnRdVxWWOW6xybq6Re0AYz3AfoA5FgLpZlaIJNKBKvkXTqofujY5eatOT1uP2bCFeXmyRBPAiMX+X5ylF0AnecpkY/kfrGbV+lJuyv51PJTnEAoL90NjQZWA/e28PAG/eU+6Fkm0gDr/BTJ6vazA6AL5XumBfbHcwW9ZKBY0voiTavEJpWTrmEmvkhibTRXdtAfN1vqu4rV0NnnO81u0hckhXlZtKxXamqQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, sstabellini@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 13 Sep 2023 09:49:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.09.2023 17:39, Simone Ballarin wrote:
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type.
> Use _AC() for macro costants that are used also in assembly files.
>
> For the sake of uniformity, the following changes are made:
> - add the 'U' suffix to macros in 'pci.h'
> - use _AC() for macros near 'X86_CR0_PG'
>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
Changes look okay, but same comment as for patch 2 as to tags (which
apparently applies to the entire series). Plus "x86/asm:" is imo pretty
misleading in the title - you're not changing any assembly code.
"x86/include:" would seem more applicable to me.
Jan
|
