[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 12 Sep 2023 11:38:45 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xKGehjcDFxDvafGb/YS+UFYDTsyd+QPlvnD0N4zYXmA=; b=h51KoXCyUjNepGuckNrS9ZVQJFqUUIe9R3WOQZAd8hkaJJ8cTpUiKasNW27LsAinA3GBR8pLXVcZJVeJzU1zmVKeEqxzgVWMHRkM/5QhWrK+7cyIOBOkhB8BPH0lnPZIV+HtgHlCwR3rTuz4Nn/w6qZk430fFv1r1Sn2ZnyvlYPMHdGvkOj/bSmU/sHNZKIIg3DQdSNZS4u6QL6S981WFK9pG4jWcLg1WVTUG/Gyj5t6zBudZpQshqil1yjSxyDtSoDDlXBm2wYQgDFd4twyUZXqsf3p7rHHr3lBtZcBRh0VoeYT8lAloJQNrOA0VVxH5xn/2h2DvjpA0Y9Z1/TPQQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ftmjGGzhs71EI5kxWe+6nBNgYGkN4fBPlyMvU/3OC+q+1uUZLg+HlqaXqIr+2SqWXbErEfp5TpTx7OP5lKzfuQpwkRA5r3hfOkwlzt64istkCnBd5o+ZdLrHy2UhxEzolHVC9sZK3T1lx1yFVwIg/ht/Itc+N/ZPLO1Pbd7us+3oySG0MJ94LUbnxetDhgFUwcslr+nYTKdkPV92B7Eus/pStiNJXh28HgmyKeI72vk+KT4SAmbFglRw7xHLK/1kubsjGIN6Xk31MWot43PAyGN4Rt/jtB09cztzP2xd4g66i2GawKy1rX/Y/jnJNENfAnPOy9iCwg9GtU7ZGJfU5w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>, "committers@xxxxxxxxxxxxxx" <committers@xxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 12 Sep 2023 09:48:13 +0000
  • Ironport-data: A9a23:CZQdVa80svhHVVUOZqU3DrUDGH+TJUtcMsCJ2f8bNWPcYEJGY0x3n GYdUGCGPK6MNzPyfYwgbY2+8xxVvJeBy9RjQFdorCs8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjVAOK6UKidYnwZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks11BjOkGlA5AdmNKkR5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklQy b9DKjINaSyPrN/s4Kzlbdc3l/UseZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuiNABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prraVx3ikCdtJTdVU8NZQsHu2904jASZJWFeXpPCjunXiYY1Af hl8Fi0G6PJaGFaQZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neSntbuAxRutqOUUnOX8rqIrTK0NjMRJGVEbigBJSMO5NzmoZ0vgwjUZsZuFravid/4Ei22x CqFxAA7jq8WhNQG1I26+07GmDOmopXVTg8z6R7TV2jj5QR8DKa1aort5VXF4PJoKIeCUkLHr HUCg9KZ7u0FEdeKjiPlaPkCGKGB4/eDLSHGhlhuD98t+lyQF2WLeIlR5HRyIRlvO8NdIzvxO haM4UVW+YNZO2asYelveYWtBs82zK/mU9P4SvTTadkIaZ90HOOawBxTiYer9ziFuCARfWsXY v93re7E4a4mNJla
  • Ironport-hdrordr: A9a23:l2WIR6jGaSTijNS5gCh/NjFl3nBQXtQji2hC6mlwRA09TyX4ra yTdZEgviMc5wx/ZJhNo7690cu7IU80hKQV3WB5B97LNmTbUQCTXeJfBOXZsljdMhy72ulB1b pxN4hSYeeAaWSSVPyKgjWFLw==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Sep 11, 2023 at 03:38:05PM -0700, Stefano Stabellini wrote:
> On Mon, 11 Sep 2023, Andrew Cooper wrote:
> > Physical CPU Hotplug does not pass the bar for being anything more than
> > experimental.  It's absolutely not tech-preview level because the only
> > demo it has had in an environment (admittedly virtual) which does
> > implement the spec in a usable way demonstrates that it doesn't function.
> > 
> > The fact no-one has noticed until now shows that the feature isn't used,
> > which comes back around full circle to the fact that Intel never made it
> > work and never shipped it.
> 
> So we actually have agreement on how to move forward
> 
> ---
> SUPPORT: downgrade Physical CPU Hotplug to Experimental
> 
> The feature is not commonly used, and we don't have hardware to test it,
> not in OSSTest, not in Gitlab, and not even ad-hoc manually by community
> members.

We could use QEMU to test, so it's not impossible to test, just that
AFAICT there aren't (that m)any users of it.

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> 
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 3461f5cf2f..02e2f6eaa8 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -48,7 +48,7 @@ For the Cortex A77 r0p0 - r1p0, see Errata 1508412.
>  
>  ### Physical CPU Hotplug

I think it would be clearer to rename this to "ACPI CPU Hotplug", as
to not be confused with the late CPU bringup done by the pvshim.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.