[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] coverage: update gcov info for newer versions of gcc
On Thu, Sep 07, 2023 at 04:41:59PM +0200, Jan Beulich wrote: > On 02.09.2023 17:11, Javi Merino wrote: > > --- a/xen/common/coverage/Makefile > > +++ b/xen/common/coverage/Makefile > > @@ -5,7 +5,9 @@ obj-y += $(call cc-ifversion,-lt,0407, \ > > gcc_3_4.o, $(call cc-ifversion,-lt,0409, \ > > gcc_4_7.o, $(call cc-ifversion,-lt,0500, \ > > gcc_4_9.o, $(call cc-ifversion,-lt,0700, \ > > - gcc_5.o, gcc_7.o)))) > > + gcc_5.o, $(call cc-ifversion,-lt,1000, \ > > + gcc_7.o, $(call cc-ifversion,-lt,1200, \ > > + gcc_10.o, gcc_12.o)))))) > > This is getting unwieldy, so I think we ought to try to limit the number > of different files we have. Already gcc_4_9.c and gcc_7.c specify the > same GCOV_COUNTERS and differ only in the version checks (which could be > combined). Therefore ... Right! I tried to keep the current structure but I agree: it is simpler if they were all combined in gcc_4_7.c. This is what linux does. I'll simplify it as you suggest and send a v2. Cheers, Javi
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |