[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/2] xen: asm-generic support
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Sep 2023 15:56:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ng0HYZOhaSnuIsrP2KuWNHb1S8yZGKsiSfx1z9VpvR0=; b=XKs6uv0pMI2cQBCU2QGHTUJX3RYem/r5waQ4O6WxEobDZctomBvz7P4Cwv7W2wxK9P6Jt2jYpdA7y1dNWIE6AbXlNWqf4UHuOUt8qrSRB+6NDvR9Ckg9c1zRZbCkAtHpuFrt7yckW0yH1WlgpHhWAorHsEd3sdLWdm5beOz6Oa/QkiFKGObRn4FDM/HUbk2/29PwSdC2312zSu4/yV3PJiDasIUanLikC846jpb8oRq7QTT0Sd4h4bjcjIa6cCgLpMd1xiEACtauof9YdOdqJrLWCbagdvMx8Y6JCNF+40jJM1VDh/n2ESGea2rGdhs35/i+VGR4aJx69ZfvAEzz7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqWLCa40NxF+Sjxaj6DI4nDgjSYvMSs7JPsSDtMyFo0kWs2O/f/bEJagzPPmcJW8ZSWBar4G/ciWqLlgLSgv/zhiMnw0UdutBAFwiBzk1CxNopC+Yn+UF+f4Ffsd968MJ+RiaJ73hJOGypkeP+SbqZuwsL6fW2II6dxtFwpp0Tb5wD91/qKvol9KM55gYAMyoOnLiZhDZQbQ9lNa2SkVmDppS33993HrvYkjaiPnNjH5ycyWN+WAK5diRbeTGxE0KpCGsNRx1Q9xpABTBS27L8PVaqtgoAiobj4iWFKrgL1rakg4ogEBP9i1kurRqp35+tvXP2cEFgdTykhE3aoiNA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 07 Sep 2023 13:56:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.09.2023 15:45, Oleksii wrote:
> On Thu, 2023-09-07 at 12:48 +0200, Jan Beulich wrote:
>> On 07.09.2023 11:32, Oleksii Kurochko wrote:
>>> --- /dev/null
>>> +++ b/xen/scripts/Makefile.asm-generic
>>> @@ -0,0 +1,53 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +# include/asm-generic contains a lot of files that are used
>>> +# verbatim by several architectures.
>>> +#
>>> +# This Makefile reads the file
>>> arch/$(SRCARCH)/include/asm/Makefile
>>> +# and for each file listed in this file with generic-y creates
>>> +# a small wrapper file in arch/$(SRCARCH)/include/generated/asm.
>>> +
>>> +PHONY := all
>>> +all:
>>> +
>>> +src := $(subst /generated,,$(obj))
>>> +
>>> +include $(srctree)/scripts/Kbuild.include
>>> +-include $(src)/Makefile
>>
>> With the definition of src above, is this correct for out-of-tree
>> builds?
> Logically you are right and I think it would be better to use
> $(srctree)/$src but it works for out-of-tree builds too.
>
> $ CONTAINER_NO_PULL=1 CONTAINER=riscv64
> ./automation/scripts/containerize make O=xen-build V=2
> XEN_TARGET_ARCH=riscv64 -C xen build
>
> $ ls -la xen/xen-build/arch/riscv/include/generated/asm/vm_event.h
> -rw-r--r--. 1 ok ok 34 вер 7 16:27 xen/xen-
> build/arch/riscv/include/generated/asm/vm_event.h
Oh, right, aiui because of VPATH being set to $(srctree), and therefore
in the absence of a Makefile in $(objtree)/$(src)/ it'll go look for
one in $(srctree)/$(src)/. Never mind then:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
