[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 net] page_pool: Cap queue size to 32k.
- To: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
- From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
- Date: Tue, 5 Sep 2023 12:57:34 +0300
- Cc: netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, ast@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, hawk@xxxxxxxxxx, john.fastabend@xxxxxxxxx, jiawenwu@xxxxxxxxxxxxxx, mengyuanlou@xxxxxxxxxxxxx, yang.lee@xxxxxxxxxxxxxxxxx, error27@xxxxxxxxx, linyunsheng@xxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, kys@xxxxxxxxxxxxx, haiyangz@xxxxxxxxxxxxx, wei.liu@xxxxxxxxxx, decui@xxxxxxxxxxxxx, longli@xxxxxxxxxxxxx, shradhagupta@xxxxxxxxxxxxxxxxxxx, linux-hwmon@xxxxxxxxxxxxxxx, michael.chan@xxxxxxxxxxxx, richardcochran@xxxxxxxxx, jdelvare@xxxxxxxx, linux@xxxxxxxxxxxx, yisen.zhuang@xxxxxxxxxx, salil.mehta@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, nbd@xxxxxxxx, john@xxxxxxxxxxx, sean.wang@xxxxxxxxxxxx, Mark-MC.Lee@xxxxxxxxxxxx, lorenzo@xxxxxxxxxx, matthias.bgg@xxxxxxxxx, angelogioacchino.delregno@xxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, saeedm@xxxxxxxxxx, leon@xxxxxxxxxx, gerhard@xxxxxxxxxxxxxxxxxxxxx, maciej.fijalkowski@xxxxxxxxx, alexanderduyck@xxxxxx, wei.fang@xxxxxxx, shenwei.wang@xxxxxxx, xiaoning.wang@xxxxxxx, linux-imx@xxxxxxx, lgirdwood@xxxxxxxxx, broonie@xxxxxxxxxx, jaswinder.singh@xxxxxxxxxx, ilias.apalodimas@xxxxxxxxxx, UNGLinuxDriver@xxxxxxxxxxxxx, horatiu.vultur@xxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, grygorii.strashko@xxxxxx, simon.horman@xxxxxxxxxxxx, vladimir.oltean@xxxxxxx, aleksander.lobakin@xxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, alexandre.torgue@xxxxxxxxxxx, joabreu@xxxxxxxxxxxx, mcoquelin.stm32@xxxxxxxxx, p.zabel@xxxxxxxxxxxxxx, thomas.petazzoni@xxxxxxxxxxx, mw@xxxxxxxxxxxx, sgoutham@xxxxxxxxxxx, gakula@xxxxxxxxxxx, sbhatta@xxxxxxxxxxx, hkelam@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, ryder.lee@xxxxxxxxxxxx, shayne.chen@xxxxxxxxxxxx, kvalo@xxxxxxxxxx, andrii@xxxxxxxxxx, martin.lau@xxxxxxxxx, song@xxxxxxxxxx, yonghong.song@xxxxxxxxx, kpsingh@xxxxxxxxxx, sdf@xxxxxxxxxx, haoluo@xxxxxxxxxx, jolsa@xxxxxxxxxx
- Delivery-date: Tue, 05 Sep 2023 09:57:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Aug 14, 2023 at 11:34:11AM +0530, Ratheesh Kannoth wrote:
> Clamp to 32k instead of returning error.
What is the motivation here? What is the real world impact for the
users?
>
> Please find discussion at
> https://lore.kernel.org/lkml/
> CY4PR1801MB1911E15D518A77535F6E51E2D308A@CY4PR1801MB1911.
> namprd18.prod.outlook.com/T/
Please don't break the URL up like this. I think normally we would just
write up a normal commit message and use the Link: tag.
Fixes: ff7d6b27f894 ("page_pool: refurbish version of page_pool code")
Link:
https://lore.kernel.org/lkml/CY4PR1801MB1911E15D518A77535F6E51E2D308A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
Signed-off-by:
> @@ -171,9 +171,10 @@ static int page_pool_init(struct page_pool *pool,
> if (pool->p.pool_size)
> ring_qsize = pool->p.pool_size;
>
> - /* Sanity limit mem that can be pinned down */
> + /* Cap queue size to 32k */
> if (ring_qsize > 32768)
> - return -E2BIG;
> + ring_qsize = 32768;
> +
>
> /* DMA direction is either DMA_FROM_DEVICE or DMA_BIDIRECTIONAL.
Don't introduce a blank line here. Checkpatch will complain if you
have to blank lines in a row. It won't complain about the patch but it
will complain if you apply the patch and then re-run checkpatch -f on
the file. (I didn't test this but it's wrong either way. :P).
regards,
dan carpenter
|