[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v11 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 4 Sep 2023 12:38:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6d5oVQokJaFdpMS/R67uh6fWE/X2RjazXQwSgFWrGBE=; b=hYVgm83QmFgEJvuFOQYfZodcnSzDRzR5sTiyALpelJ2sk+M4NZ2JRuMyER2+mBNDbhom1/fNuWTOj4aenUb0NgWDxh4/5GXg/gpUqcQFjqQ067LOLlZp7MSjH3zno84ibIHiRVJ+vsTZmIdrQchjr+GrKq/uqNCivHEorbiy085Fc+rZnWPxU7NFF4Jlylq4GVZvNk5/Cs822ma5oZvvLVGW6Oy5ZgObZSD4u0lNDMrSvnDHCqxfwRPa8ILC53aRU2ab2ChYG7i6u2Znu1h+8LPhRIIX/+bOI2fvuKzEVYXnt8JL33RzoyAXbn/3jxGLpqUbofk/tKMrBlBgSI4QCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eyFoTEYqEVc2zRQ/nrRbUkvoVQjllobighRYZmhhL+mKh6R+8rVq6g44RFAMCn7UHhFFMIxxaEE8Jq7WPxH31LRD9Dy08n5wlMF8uKDoSX10uPvxPSC8SCNtWyMj0IbvLCQ8eg4Cn/jtj5Vy4Dgq9nM9axjgCVyvJxmx0FDXJovcJP5iiZv8kAFj7fCDOzM8B9YXUxT4VsozhWH3eaofihFk50J3xC2tc2k9smMR07nqG2CMb78gpLvwA0KuSv6NcPXdENiIo4aNqgFN3zDTKRwmltTmEgjC5Yk0m8p0ITVorqtyx/SMAPYcg+h0TFBw5y4OCmZCF0Kzmqf/v1xyCA==
- Cc: <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 04 Sep 2023 10:38:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/09/2023 06:59, Vikram Garhwal wrote:
> Add remove_device callback for removing the device entry from smmu-master
> using
> following steps:
> 1. Find if SMMU master exists for the device node.
> 2. Check if device is currently in use.
Just like in v10: you are not checking it. I asked you to add a check following
Julien suggestion
but you did not reply to it. Even if you do not want to add this extra layer of
protection, you
should mention that you rely on a check in iommu_remove_dt_device() instead.
You can wait for Stefano
to give his opinion (and possibly ack this patch as is).
~Michal
|
