[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] CI: Always move the bisect build log back
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 23 Aug 2023 19:05:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4nmTV/b9ScOHn0uyS/cUErv+YXN36z3aGvNJbNYKmiY=; b=OdjdWr85CjA1Qeq5wNF0Dmw6w6YORI82TREVGMgeKYoOI8NXm3JULV7EfNPvK9lE2dgox8PABtq1d290oRNOya9+I0NCjIJAXjPWrpqVAWGhuvI9zFSsXev1UyxE6wT2fjrLkJRyJaiyfdGRXkaecpdjkN0qhobfQwxIoRPrv7LFf6QVGkqDkt50WFvFn28Ma1w5ma3phs87659hjroakC/L/8iJzXri/6Sn0GtVZmZG6OLutwv+4lgNQtkoEUvZPgfRHI9nzwQM74ZJF6vaTyFMxonvcdssPiKFkciZS7gIOkTiy7vi3yF0v5Fpm3C9LiARlexyyde4NUULbZCteA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PvCo5y2hfxDkaWnHGefApqctpe2MbE7HsclPW9fvuN1i/pzCKWD5zwcGRVn3Xsimreq5vrhV5pIR4AmQzShiApXJd3yisweACMg0xhmik7wzJe/uNN+AKgRBqdIP80rYdqlZwHyw0oPuehkjFpFYp1c5BPnykYQ6X16Y223PF/BacTZ1jPtGrPPZTE3ekp49VJ0CbMjWNko0NcqMMjYqT4nF2RoQyW/cQiWaODmdaT/oTFWFECac8+jqDzNN8Y5h0rsDvLEtQYh+5ocDuT17jXdzUoPXJAOAe8bxuR8QuXt8xDikID5SEtaaMAuwfEO0pgjf4VrPfKMGxI0qd6p0Fw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 23 Aug 2023 18:06:23 +0000
- Ironport-data: A9a23:5ffxcqxfNyNWPkhnnmN6t+cBxyrEfRIJ4+MujC+fZmUNrF6WrkVTy DdNXGCOOfvcambwKtAkOdi09k0D7JaHydVgGVForSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuP6sT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV5U8 eUVBQk9UjDZqduGkZ2YQcl13e12eaEHPKtH0p1h5RfwKK58BLzmGODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVkF0ZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiCdtKTODnr5aGhnXK4mEcARYoBGGr+9ydhGqbQ/9DB 249r39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOv8YsSTsn/ lSAhd/uCHpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLnW0ophfGT9ImHKvuiNTwQWv02 2rS8Hl4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CFsdxS2hAzWMaywqQ==
- Ironport-hdrordr: A9a23:a8pRjK5sumFH3wgjAgPXwD7XdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsyMc7Qx6ZJhOo7+90cW7L080sKQFg7X5Xo3SOzUO2lHYT72KhLGKq1Hd8m/Fh4tgPM 9bGJSWY+eAaWSS4/ya3OG5eexQv+Vu8sqT9JnjJ6EGd3AaV0lihT0JejpyCidNNXB77QJSLu vg2iJAzQDQAUg/X4CAKVQuefPMnNHPnIKOW297O/Z2gDP+9g9B8dTBYmKl4is=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/08/2023 4:23 pm, Anthony PERARD wrote:
> On failure of "build"-each-commit script, the next command that move
> the log back into the build directory isn't executed. Fix that by
> using "after_script" which is always executed even if the main
> "script" fails. (We would still miss the log when the jobs times out.)
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> automation/gitlab-ci/test.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
> index 810631bc46..5099f2e6b6 100644
> --- a/automation/gitlab-ci/test.yaml
> +++ b/automation/gitlab-ci/test.yaml
> @@ -140,6 +140,7 @@ build-each-commit-gcc:
> CC: gcc
> script:
> - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}}
> TIP=${TIP_SHA:-${CI_COMMIT_SHA}} ./automation/gitlab-ci/build-each-commit.sh
> 2>&1 | tee ../build-each-commit-gcc.log
> + after_script:
> - mv ../build-each-commit-gcc.log .
> artifacts:
> paths:
Thanks for looking into this, and yeah that is dumb, but why play games
with the parent directory?
$ git diff
diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
index 810631bc4624..b4c2f22a1b07 100644
--- a/automation/gitlab-ci/test.yaml
+++ b/automation/gitlab-ci/test.yaml
@@ -136,11 +136,11 @@ build-each-commit-gcc:
extends: .test-jobs-common
variables:
CONTAINER: debian:stretch
+ LOGFILE: build-each-commit-gcc.log
XEN_TARGET_ARCH: x86_64
CC: gcc
script:
- - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}}
TIP=${TIP_SHA:-${CI_COMMIT_SHA}}
./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee
../build-each-commit-gcc.log
- - mv ../build-each-commit-gcc.log .
+ - BASE=${BASE_SHA:-${CI_COMMIT_BEFORE_SHA}}
TIP=${TIP_SHA:-${CI_COMMIT_SHA}}
./automation/gitlab-ci/build-each-commit.sh 2>&1 | tee ${LOGFILE}
artifacts:
paths:
- '*.log'
This is prevailing style of the other tests, and also e.g. won't emit
the (whole) log file if e.g. disk space fills up.
~Andrew
|
