[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] libxl/CPUID: drop two more feature flag table entries


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 23 Aug 2023 09:21:26 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tf0oYnqYn/LfglmQ1aNeY2174tGgepv6jmssSRTXF/c=; b=erIUOeuTFU/z8k2zL1QQTWKGaLNFEC+jGuHi51ZHwOvwKf+82JJgWy55OvVBp39u3ieTc57b3AuNuHlc1YGzZugRWOTeQxxghZYnlMKDP7bamovUGrJjt7RJ6gIC6NBlIao/LTsn2BL9BwbcHd3v63njpT2e9a3wT3Rx7qh6JWgIQEkCCTnQpkcyBCv+7uR3dyo+Yvak6FwD+3N03JXsnSeGMAcs3512TThnULa+DJq6UXw+3mBJJR7KLxgL4S6CZqD9T9P+R1MFrf67ni2jENP7q14ecqw25hqJOB8B1Y9GTGZXkJEC5ohiqsfyflOJj0w+c9gRMgnAI7rAD8HmGg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hijwJGXS6487shl6WS0kjyPd59wunI/aNhz4lZ9ceVD55xbmxR/DZLIE8/J1s0L0BgOHJXaQIT9EmeAJPHl8xjAufU/5PvPO/tqoCXuxdOZ7SpP6/s8T3s76k7fVwkkraQBRctq+x5cI2bgClQ50aREX2htJFNiO4XaxzMiC5vDuR9Cx2QaJQf5J3A1b4Xr1i91ZFilZxc3BiOYJhojfNL6Ag9X7OT5HjshH/P71qxfOd8NpzlVvFc9zaMqq/97R3H9oRIEOdBcnEheOMwVDqgCf5SWQz4itKS0FHOILdPPBhVzf7OZGI2iL9DuL0F28bdfbp3Rb4FrnU+IFu2Vvsg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 23 Aug 2023 07:21:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Two entries were left in place by d638fe233cb3 ("libxl: use the cpuid
feature names from cpufeatureset.h"), despite matching the generated
names.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Permitting "psn", "ia64, "cntxid", and "perfctr_*" when the hypervisor
doesn't even know of the bits (perhaps wrongly so) is kind of odd as
well. Permitting bits like "est", which the hypervisor knows of but
doesn't expose to guests, is also questionable.

I wouldn't really call this a bug fix (the entries are simply redundant,
but nothing bad would happen with them there), hence no Fixes: tag.

--- a/tools/libs/light/libxl_cpuid.c
+++ b/tools/libs/light/libxl_cpuid.c
@@ -260,7 +260,6 @@ int libxl_cpuid_parse_config(libxl_cpuid
         {"clfsh",        0x00000001, NA, CPUID_REG_EDX, 19,  1},
         {"tm",           0x00000001, NA, CPUID_REG_EDX, 29,  1},
         {"ia64",         0x00000001, NA, CPUID_REG_EDX, 30,  1},
-        {"pbe",          0x00000001, NA, CPUID_REG_EDX, 31,  1},
 
         {"arat",         0x00000006, NA, CPUID_REG_EAX,  2,  1},
 
@@ -279,7 +278,6 @@ int libxl_cpuid_parse_config(libxl_cpuid
         {"invtsc",       0x80000007, NA, CPUID_REG_EDX,  8,  1},
 
         {"ppin",         0x80000008, NA, CPUID_REG_EBX, 23,  1},
-        {"btc-no",       0x80000008, NA, CPUID_REG_EBX, 29,  1},
 
         {"nc",           0x80000008, NA, CPUID_REG_ECX,  0,  8},
         {"apicidsize",   0x80000008, NA, CPUID_REG_ECX, 12,  4},



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.