Re: [PATCH 2/3] xen/arm: vgic: Use 'unsigned int' rather than 'int' whenever it is possible

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 18/08/2023 08:02, Michal Orzel wrote:
> On 17/08/2023 23:43, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Switch to unsigned int for the return/parameters of the following
> > functions:
> >      * REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
> >        'n' doesn't need to be size specific.
> >      * vgic_rank_offset(): 'b' (number of bits), 'n' (register index),
> >        's' (size of the access) are always positive.
> >      * vgic_{enable, disable}_irqs(): 'n' (rank index) is always positive
> >      * vgic_get_virq_type(): 'n' (rank index) and 'index' (register
> >        index) are always positive.
> It looks like you forgot to mention the modification done to 'vgic_get_rank()'
I have added:

        * vgic_get_rank(): 'rank' is an index and therefore always 
positive.
> With this addressed:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks!

Cheers,

--
Julien Grall